From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16770 invoked by alias); 23 Nov 2009 22:25:53 -0000 Received: (qmail 16762 invoked by uid 22791); 23 Nov 2009 22:25:53 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Nov 2009 22:25:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 202602BABA2; Mon, 23 Nov 2009 17:25:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lYKaqwNRcB3Q; Mon, 23 Nov 2009 17:25:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C93852BAB56; Mon, 23 Nov 2009 17:25:45 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6EE04F5905; Mon, 23 Nov 2009 17:25:43 -0500 (EST) Date: Mon, 23 Nov 2009 22:25:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [commit] precord watchpoint tests Message-ID: <20091123222543.GB5595@adacore.com> References: <4B0AEBBB.6050904@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B0AEBBB.6050904@vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00516.txt.bz2 > +# FIXME 'set exec-dir' command should give some output so we can test. > +gdb_test "set exec-direction forward" "" "set forward" This is really a minor comment, so feel free to ignore. IMO, I don't necessarily think that "set exec-dir" should produce some output (that is not consistent with quite a few of our "set ..." commands), particularly if the sole purpose of that output is to allow the testsuite to verify that the command worked. If testing is the only point of output, then perhaps you should consider using gdb_test_multiple. I am not 100% sure, but I think that this routine will allow you to test that the command produced exactly no output. It would be nice if we could just address the issue right now and be done with it, rather than keeping duplicating FIXMEs like this. Either way - whether we decide to add some output or not, taking care of the FIXME shouldn't be too time consuming... (assuming gdb_test_multiple works as I think it does). -- Joel