From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix regression in always-inserted breakpoints mode.
Date: Fri, 20 Nov 2009 20:03:00 -0000 [thread overview]
Message-ID: <20091120200253.GB18007@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <200911201600.37742.pedro@codesourcery.com>
On Fri, 20 Nov 2009 17:00:37 +0100, Pedro Alves wrote:
> On Friday 20 November 2009 11:38:21, Jan Kratochvil wrote:
> > I will check-in the [obv] patch below after you check it in.
>
> Good idea. I've checked mine in. Go ahead.
Checked-in:
http://sourceware.org/ml/gdb-cvs/2009-11/msg00179.html
> > > There's another problem with this for loop. The
> > > breakpoint_address_match is too strict when debugging
> > > more than one inferior. Even if breakpoint_address_match
> > > fails due to address space mismatch, there could be other
> > > locations with the same address following loc2p.
> >
> > This is unrelated to the regression from me.
>
> We were always looping over all locations previously,
> and breakpoint_address_match wasn't a part of the for
> loop conditional, so it is.
OK, I admit this was also a regression by my patch.
The rebase on the multi-inferior patch was done just as an "obvious"
pre-checkin update...
Sorry,
Jan
prev parent reply other threads:[~2009-11-20 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 2:12 Pedro Alves
2009-11-20 11:39 ` Jan Kratochvil
2009-11-20 16:01 ` Pedro Alves
2009-11-20 20:03 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120200253.GB18007@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox