From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17359 invoked by alias); 20 Nov 2009 20:03:55 -0000 Received: (qmail 17302 invoked by uid 22791); 20 Nov 2009 20:03:55 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Nov 2009 20:03:05 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAKK2upV024252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Nov 2009 15:02:56 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAKK2riq022291 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Nov 2009 15:02:55 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nAKK2rgH018258; Fri, 20 Nov 2009 21:02:53 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nAKK2rFU018256; Fri, 20 Nov 2009 21:02:53 +0100 Date: Fri, 20 Nov 2009 20:03:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Fix regression in always-inserted breakpoints mode. Message-ID: <20091120200253.GB18007@host0.dyn.jankratochvil.net> References: <200911200211.18854.pedro@codesourcery.com> <20091120113821.GA30659@host0.dyn.jankratochvil.net> <200911201600.37742.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911201600.37742.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00445.txt.bz2 On Fri, 20 Nov 2009 17:00:37 +0100, Pedro Alves wrote: > On Friday 20 November 2009 11:38:21, Jan Kratochvil wrote: > > I will check-in the [obv] patch below after you check it in. > > Good idea. I've checked mine in. Go ahead. Checked-in: http://sourceware.org/ml/gdb-cvs/2009-11/msg00179.html > > > There's another problem with this for loop. The > > > breakpoint_address_match is too strict when debugging > > > more than one inferior. Even if breakpoint_address_match > > > fails due to address space mismatch, there could be other > > > locations with the same address following loc2p. > > > > This is unrelated to the regression from me. > > We were always looping over all locations previously, > and breakpoint_address_match wasn't a part of the for > loop conditional, so it is. OK, I admit this was also a regression by my patch. The rebase on the multi-inferior patch was done just as an "obvious" pre-checkin update... Sorry, Jan