From: Daniel Jacobowitz <drow@false.org>
To: Cary Coutant <ccoutant@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix "Cannot find DIE" error with -gdwarf-4
Date: Mon, 09 Nov 2009 21:35:00 -0000 [thread overview]
Message-ID: <20091109213548.GA18684@caradoc.them.org> (raw)
In-Reply-To: <c17be2b30911091331x6b3d25c9g363ac3907a36710a@mail.gmail.com>
On Mon, Nov 09, 2009 at 01:31:32PM -0800, Cary Coutant wrote:
> This patch fixes a problem in read_import_statement, where we get a
> "Cannot find DIE" error when trying to process a DW_AT_import
> attribute that refers to a DIE in a different CU. When finding the
> referenced DIE, the current code clobbers the CU parameter, but later
> calls determine_prefix(die, cu), assuming that CU is still the CU that
> contains DIE.
>
> I found this problem using -gdwarf-4 and DW_FORM_sig8, but I don't
> think this problem was introduced with the support for type units. The
> same problem could have occurred given a compiler that splits debug
> info into separate compilation units by include file, using
> DW_FORM_ref_addr to refer to a DIE in a different CU.
>
> OK for trunk?
OK.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2009-11-09 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 21:31 Cary Coutant
2009-11-09 21:35 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109213548.GA18684@caradoc.them.org \
--to=drow@false.org \
--cc=ccoutant@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox