From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26898 invoked by alias); 9 Nov 2009 21:35:59 -0000 Received: (qmail 26888 invoked by uid 22791); 9 Nov 2009 21:35:59 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 21:35:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0B46710D74; Mon, 9 Nov 2009 21:35:50 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id EC0ED10D6B; Mon, 9 Nov 2009 21:35:49 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N7btt-0004vD-09; Mon, 09 Nov 2009 16:35:49 -0500 Date: Mon, 09 Nov 2009 21:35:00 -0000 From: Daniel Jacobowitz To: Cary Coutant Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix "Cannot find DIE" error with -gdwarf-4 Message-ID: <20091109213548.GA18684@caradoc.them.org> Mail-Followup-To: Cary Coutant , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00189.txt.bz2 On Mon, Nov 09, 2009 at 01:31:32PM -0800, Cary Coutant wrote: > This patch fixes a problem in read_import_statement, where we get a > "Cannot find DIE" error when trying to process a DW_AT_import > attribute that refers to a DIE in a different CU. When finding the > referenced DIE, the current code clobbers the CU parameter, but later > calls determine_prefix(die, cu), assuming that CU is still the CU that > contains DIE. > > I found this problem using -gdwarf-4 and DW_FORM_sig8, but I don't > think this problem was introduced with the support for type units. The > same problem could have occurred given a compiler that splits debug > info into separate compilation units by include file, using > DW_FORM_ref_addr to refer to a DIE in a different CU. > > OK for trunk? OK. -- Daniel Jacobowitz CodeSourcery