From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: vladimir@codesourcery.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [m68k] correct m68k_convert_register_p for coldfire
Date: Sun, 08 Nov 2009 12:29:00 -0000 [thread overview]
Message-ID: <200911081228.nA8CSD5L012111@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <200911071402.19931.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 7 Nov 2009 14:02:19 +0300)
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 7 Nov 2009 14:02:19 +0300
>
> On Saturday 07 November 2009 Mark Kettenis wrote:
>
> > > From: Vladimir Prus <vladimir@codesourcery.com>
> > > Date: Fri, 06 Nov 2009 20:24:47 +0300
> > > > Please don't apply this as is without at least trying to
> > > > build it... current_gdbarch doesn't exist anymore.
> > >
> > > Doh! Here's what I've ended up checking it.
> >
> > But that doesn't make any sense. On a real m68k,
> > register_type(gdbarch, M68K_FP0_REGNUM) will return
> > m68881_ext_type(gdbarch) and on coldfire, type !=
> > m68881_ext_type(gdbarch) is probably always true.
>
> Does the correction in
>
> http://sourceware.org/ml/gdb-cvs/2009-11/msg00044.html
>
> make the code sensible?
It does. Thanks.
prev parent reply other threads:[~2009-11-08 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 13:04 Vladimir Prus
2009-11-06 13:18 ` Mark Kettenis
2009-11-06 13:23 ` Pedro Alves
2009-11-06 17:25 ` Vladimir Prus
2009-11-06 18:36 ` Daniel Jacobowitz
2009-11-06 19:27 ` Vladimir Prus
2009-11-06 23:27 ` Mark Kettenis
2009-11-07 11:02 ` Vladimir Prus
2009-11-08 12:29 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911081228.nA8CSD5L012111@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox