From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20890 invoked by alias); 8 Nov 2009 12:29:47 -0000 Received: (qmail 20881 invoked by uid 22791); 8 Nov 2009 12:29:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 08 Nov 2009 12:29:42 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id nA8CSF72028364; Sun, 8 Nov 2009 13:28:15 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id nA8CSD5L012111; Sun, 8 Nov 2009 13:28:13 +0100 (CET) Date: Sun, 08 Nov 2009 12:29:00 -0000 Message-Id: <200911081228.nA8CSD5L012111@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: vladimir@codesourcery.com CC: gdb-patches@sources.redhat.com In-reply-to: <200911071402.19931.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 7 Nov 2009 14:02:19 +0300) Subject: Re: [m68k] correct m68k_convert_register_p for coldfire References: <200911061604.18419.vladimir@codesourcery.com> <200911062325.nA6NPZHv008499@glazunov.sibelius.xs4all.nl> <200911071402.19931.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00129.txt.bz2 > From: Vladimir Prus > Date: Sat, 7 Nov 2009 14:02:19 +0300 > > On Saturday 07 November 2009 Mark Kettenis wrote: > > > > From: Vladimir Prus > > > Date: Fri, 06 Nov 2009 20:24:47 +0300 > > > > Please don't apply this as is without at least trying to > > > > build it... current_gdbarch doesn't exist anymore. > > > > > > Doh! Here's what I've ended up checking it. > > > > But that doesn't make any sense. On a real m68k, > > register_type(gdbarch, M68K_FP0_REGNUM) will return > > m68881_ext_type(gdbarch) and on coldfire, type != > > m68881_ext_type(gdbarch) is probably always true. > > Does the correction in > > http://sourceware.org/ml/gdb-cvs/2009-11/msg00044.html > > make the code sensible? It does. Thanks.