Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Nathan Sidwell <nathan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [testsuite] check for languages consistently
Date: Sat, 07 Nov 2009 02:22:00 -0000	[thread overview]
Message-ID: <20091107022153.GM4557@adacore.com> (raw)
In-Reply-To: <4AF058B6.2070808@codesourcery.com>

> 2009-11-03  Nathan Sidwell  <nathan@codesourcery.com>
> 
> 	* lib/gdb.exp (gdb_compile_test): New.
> 	(skip_ada_tests, skip_java_tests): New.
> 	(gdb_compile): Use gdb_compile_test for f77.
> 	* lib/ada.exp (gdb_compile_ada): Use gdb_compile_test to record result.
> 	* lib/java.exp (compile_java_from_source): Remove runtests check,
> 	use gdb_compile_test to record result.
> 	* gdb.ada/packed_array.exp, gdb.ada/fixed_points.exp,
> 	gdb.ada/exec_changed.exp, gdb.ada/start.exp,
> 	gdb.ada/watch_arg.exp, gdb.ada/null_record.exp,
> 	gdb.ada/array_return.exp, gdb.ada/arrayidx.exp,
> 	gdb.mi/mi-var-child-f.exp, gdb.fortran/types.exp,
> 	gdb.fortran/array-element.exp, gdb.fortran/subarray.exp,
> 	gdb.fortran/derived-type.exp, gdb.fortran/exprs.exp,
> 	gdb.java/jmisc.exp, gdb.java/jmisc1.exp, gdb.java/jprint.exp,
> 	gdb.java/jv-print.exp, gdb.java/jmain.exp: Add language skip,
> 	adjust gdb_compile invocations.

Looks OK to me, except for one question. Did you test this with a java
compiler around, by any chance? This is the only part that I'm not sure
about. I just don't understand exactly what the bits you are removing
are trying to do (I'm reading the dejagnu documentation and it's not
quite helping...).

-- 
Joel


  reply	other threads:[~2009-11-07  2:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 16:22 Nathan Sidwell
2009-11-07  2:22 ` Joel Brobecker [this message]
2009-11-09 12:06   ` Nathan Sidwell
2009-11-09 17:07     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091107022153.GM4557@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nathan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox