From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14920 invoked by alias); 7 Nov 2009 02:22:11 -0000 Received: (qmail 14909 invoked by uid 22791); 7 Nov 2009 02:22:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Nov 2009 02:22:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2EBC32BAB6A; Fri, 6 Nov 2009 21:22:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id K8qcby9Ja5Te; Fri, 6 Nov 2009 21:22:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EA5702BAB2D; Fri, 6 Nov 2009 21:22:04 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C1F0BF5905; Fri, 6 Nov 2009 18:21:53 -0800 (PST) Date: Sat, 07 Nov 2009 02:22:00 -0000 From: Joel Brobecker To: Nathan Sidwell Cc: gdb-patches@sourceware.org Subject: Re: [testsuite] check for languages consistently Message-ID: <20091107022153.GM4557@adacore.com> References: <4AF058B6.2070808@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF058B6.2070808@codesourcery.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00122.txt.bz2 > 2009-11-03 Nathan Sidwell > > * lib/gdb.exp (gdb_compile_test): New. > (skip_ada_tests, skip_java_tests): New. > (gdb_compile): Use gdb_compile_test for f77. > * lib/ada.exp (gdb_compile_ada): Use gdb_compile_test to record result. > * lib/java.exp (compile_java_from_source): Remove runtests check, > use gdb_compile_test to record result. > * gdb.ada/packed_array.exp, gdb.ada/fixed_points.exp, > gdb.ada/exec_changed.exp, gdb.ada/start.exp, > gdb.ada/watch_arg.exp, gdb.ada/null_record.exp, > gdb.ada/array_return.exp, gdb.ada/arrayidx.exp, > gdb.mi/mi-var-child-f.exp, gdb.fortran/types.exp, > gdb.fortran/array-element.exp, gdb.fortran/subarray.exp, > gdb.fortran/derived-type.exp, gdb.fortran/exprs.exp, > gdb.java/jmisc.exp, gdb.java/jmisc1.exp, gdb.java/jprint.exp, > gdb.java/jv-print.exp, gdb.java/jmain.exp: Add language skip, > adjust gdb_compile invocations. Looks OK to me, except for one question. Did you test this with a java compiler around, by any chance? This is the only part that I'm not sure about. I just don't understand exactly what the bits you are removing are trying to do (I'm reading the dejagnu documentation and it's not quite helping...). -- Joel