From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] AC_SYS_LARGEFILE
Date: Tue, 03 Nov 2009 09:44:00 -0000 [thread overview]
Message-ID: <20091103094427.GA6724@host0.dyn.jankratochvil.net> (raw)
Hi,
other sourceware tree parts already contain AC_SYS_LARGEFILE affecting ABI
compatibility on 32bit hosts.
While I was grepping for `off_t' before found now there is now already an ABI
incompatiblity for `struct stat' also affected by AC_SYS_LARGEFILE which is
declared in gdb/rs6000-nat.c but filled through bfd_stat() in bfd/ . It does
corrupt the gdb stack. Non-gdb/ sourceware parts were patched by me before.
For gdb/ the patch is already being tested for some time
http://cvs.fedora.redhat.com/viewvc/rpms/gdb/devel/gdb-6.8-bz457187-largefile.patch?content-type=text%2Fplain&view=co
so submitting this patch also for gdb/ as a prerequisite to fix another
FSF GDB regression from me:
Recent separate debug file warning caused Debian regressions
http://sourceware.org/ml/gdb-patches/2009-11/msg00034.html
The patch was originally introduced to read elf64-i386 Linux kernel core dumps
on PAE systems (>4GB RAM). But the existing distro testcase is not applicable
for FSF GDB as it depends on GDB configure options not guaranteeable for FSF
GDB.
http://cvs.fedora.redhat.com/viewvc/rpms/gdb/devel/gdb-6.8-bz457187-largefile-test.patch?content-type=text%2Fplain&view=co
Regression tested {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
Thanks,
Jan
gdb/
2009-03-02 Jan Kratochvil <jan.kratochvil@redhat.com>
* configure.ac: Call AC_SYS_LARGEFILE.
* config.in: Regenerate.
* configure: Regenerate.
--- gdb-6.8.50.20090909.orig/gdb/configure.ac 2009-09-09 20:08:04.000000000 +0200
+++ gdb-6.8.50.20090909/gdb/configure.ac 2009-09-09 20:11:04.000000000 +0200
@@ -28,6 +28,7 @@ AM_MAINTAINER_MODE
AC_PROG_CC
AC_USE_SYSTEM_EXTENSIONS
gl_EARLY
+AC_SYS_LARGEFILE
AM_PROG_CC_STDC
AC_CONFIG_AUX_DIR(..)
next reply other threads:[~2009-11-03 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 9:44 Jan Kratochvil [this message]
2009-11-03 14:00 ` Joel Brobecker
2009-11-03 16:55 ` Tom Tromey
2009-11-03 17:07 ` Tom Tromey
2009-11-11 5:09 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103094427.GA6724@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox