From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7713 invoked by alias); 3 Nov 2009 09:44:38 -0000 Received: (qmail 7701 invoked by uid 22791); 3 Nov 2009 09:44:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 09:44:32 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA39iVLI024874 for ; Tue, 3 Nov 2009 04:44:31 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA39iTJq023590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 3 Nov 2009 04:44:30 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nA39iSbi007217 for ; Tue, 3 Nov 2009 10:44:28 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nA39iSTt007216 for gdb-patches@sourceware.org; Tue, 3 Nov 2009 10:44:28 +0100 Date: Tue, 03 Nov 2009 09:44:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] AC_SYS_LARGEFILE Message-ID: <20091103094427.GA6724@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00047.txt.bz2 Hi, other sourceware tree parts already contain AC_SYS_LARGEFILE affecting ABI compatibility on 32bit hosts. While I was grepping for `off_t' before found now there is now already an ABI incompatiblity for `struct stat' also affected by AC_SYS_LARGEFILE which is declared in gdb/rs6000-nat.c but filled through bfd_stat() in bfd/ . It does corrupt the gdb stack. Non-gdb/ sourceware parts were patched by me before. For gdb/ the patch is already being tested for some time http://cvs.fedora.redhat.com/viewvc/rpms/gdb/devel/gdb-6.8-bz457187-largefile.patch?content-type=text%2Fplain&view=co so submitting this patch also for gdb/ as a prerequisite to fix another FSF GDB regression from me: Recent separate debug file warning caused Debian regressions http://sourceware.org/ml/gdb-patches/2009-11/msg00034.html The patch was originally introduced to read elf64-i386 Linux kernel core dumps on PAE systems (>4GB RAM). But the existing distro testcase is not applicable for FSF GDB as it depends on GDB configure options not guaranteeable for FSF GDB. http://cvs.fedora.redhat.com/viewvc/rpms/gdb/devel/gdb-6.8-bz457187-largefile-test.patch?content-type=text%2Fplain&view=co Regression tested {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. Thanks, Jan gdb/ 2009-03-02 Jan Kratochvil * configure.ac: Call AC_SYS_LARGEFILE. * config.in: Regenerate. * configure: Regenerate. --- gdb-6.8.50.20090909.orig/gdb/configure.ac 2009-09-09 20:08:04.000000000 +0200 +++ gdb-6.8.50.20090909/gdb/configure.ac 2009-09-09 20:11:04.000000000 +0200 @@ -28,6 +28,7 @@ AM_MAINTAINER_MODE AC_PROG_CC AC_USE_SYSTEM_EXTENSIONS gl_EARLY +AC_SYS_LARGEFILE AM_PROG_CC_STDC AC_CONFIG_AUX_DIR(..)