From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 3/3] debug-file-directory with multiple components
Date: Thu, 22 Oct 2009 20:22:00 -0000 [thread overview]
Message-ID: <20091022202205.GA12911@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m3zl7jguh9.fsf@fleche.redhat.com>
On Thu, 22 Oct 2009 20:21:38 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> It should be a backward compatible extension as DIRNAME_SEPARATOR
> Jan> should never be a valid part of a single DEBUG_FILE_DIRECTORY
> Jan> component.
>
> Why is that? It doesn't seem really impossible to me, just unlikely.
>
> FWIW, I don't think this should actually block this patch. If this were
> a real problem we would need a solution to it anywhere we have a list of
> directories.
It was a wrong wording for me, it was expressing your opinion "unlikely".
> The code bits look ok to me.
> But, please wait a few days to see if there are any objections.
OK, thanks for the review.
Thanks,
Jan
next prev parent reply other threads:[~2009-10-22 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 23:10 Jan Kratochvil
2009-10-22 18:21 ` Tom Tromey
2009-10-22 20:22 ` Jan Kratochvil [this message]
2009-11-02 15:00 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022202205.GA12911@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox