From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24640 invoked by alias); 22 Oct 2009 20:22:18 -0000 Received: (qmail 24630 invoked by uid 22791); 22 Oct 2009 20:22:18 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 20:22:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9MKMDZh020051 for ; Thu, 22 Oct 2009 16:22:13 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9MKM8VF005000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Oct 2009 16:22:12 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n9MKM7aW013135; Thu, 22 Oct 2009 22:22:08 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n9MKM6kj013131; Thu, 22 Oct 2009 22:22:06 +0200 Date: Thu, 22 Oct 2009 20:22:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/3] debug-file-directory with multiple components Message-ID: <20091022202205.GA12911@host0.dyn.jankratochvil.net> References: <20091021231039.GD2658@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00543.txt.bz2 On Thu, 22 Oct 2009 20:21:38 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > Jan> It should be a backward compatible extension as DIRNAME_SEPARATOR > Jan> should never be a valid part of a single DEBUG_FILE_DIRECTORY > Jan> component. > > Why is that? It doesn't seem really impossible to me, just unlikely. > > FWIW, I don't think this should actually block this patch. If this were > a real problem we would need a solution to it anywhere we have a list of > directories. It was a wrong wording for me, it was expressing your opinion "unlikely". > The code bits look ok to me. > But, please wait a few days to see if there are any objections. OK, thanks for the review. Thanks, Jan