Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix for PR gdb/10819
Date: Thu, 22 Oct 2009 05:48:00 -0000	[thread overview]
Message-ID: <20091022054758.GA15116@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <8ac60eac0910212148w24f44d53xfa6bedd7e12b41d1@mail.gmail.com>

On Thu, 22 Oct 2009 06:48:06 +0200, Paul Pluzhnikov wrote:
> Attached is a patch to fix PR gdb/10819
> http://sourceware.org/bugzilla/show_bug.cgi?id=10819
[...]
> +  if (cie_table->num_entries == 0)
> +    return NULL;
> +
>    p_cie = bsearch (&cie_pointer, cie_table->entries, cie_table->num_entries,
>                     sizeof (cie_table->entries[0]), bsearch_cie_cmp);
>    if (p_cie != NULL)

I would find appropriate there a comment it is a Solaris bug workaround, the
condition looks to me as clearly redundant there now.


Thanks,
Jan


  reply	other threads:[~2009-10-22  5:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22  4:48 Paul Pluzhnikov
2009-10-22  5:48 ` Jan Kratochvil [this message]
2009-10-22  6:14   ` Paul Pluzhnikov
2009-10-22 10:43     ` Pedro Alves
2009-10-22 11:09       ` Andreas Schwab
2009-10-22 15:34         ` Paul Pluzhnikov
2009-10-22 16:30           ` Paul Pluzhnikov
2009-10-22 17:44             ` Tom Tromey
2009-10-22 18:31               ` Paul Pluzhnikov
2009-10-22 20:13                 ` Tom Tromey
2009-10-22 20:46                   ` Paul Pluzhnikov
2009-10-22 18:11     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091022054758.GA15116@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox