From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67891-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9059 invoked by alias); 22 Oct 2009 05:48:15 -0000
Received: (qmail 9048 invoked by uid 22791); 22 Oct 2009 05:48:14 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 05:48:10 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9M5m8fV005708 	for <gdb-patches@sourceware.org>; Thu, 22 Oct 2009 01:48:08 -0400
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9M5m2vu028613 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) 	for <gdb-patches@sourceware.org>; Thu, 22 Oct 2009 01:48:07 -0400
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n9M5m1xt015759; 	Thu, 22 Oct 2009 07:48:01 +0200
Received: (from jkratoch@localhost) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n9M5lw72015751; 	Thu, 22 Oct 2009 07:47:58 +0200
Date: Thu, 22 Oct 2009 05:48:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix for PR gdb/10819
Message-ID: <20091022054758.GA15116@host0.dyn.jankratochvil.net>
References: <8ac60eac0910212148w24f44d53xfa6bedd7e12b41d1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8ac60eac0910212148w24f44d53xfa6bedd7e12b41d1@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00514.txt.bz2

On Thu, 22 Oct 2009 06:48:06 +0200, Paul Pluzhnikov wrote:
> Attached is a patch to fix PR gdb/10819
> http://sourceware.org/bugzilla/show_bug.cgi?id=10819
[...]
> +  if (cie_table->num_entries == 0)
> +    return NULL;
> +
>    p_cie = bsearch (&cie_pointer, cie_table->entries, cie_table->num_entries,
>                     sizeof (cie_table->entries[0]), bsearch_cie_cmp);
>    if (p_cie != NULL)

I would find appropriate there a comment it is a Solaris bug workaround, the
condition looks to me as clearly redundant there now.


Thanks,
Jan