Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Eager <eager@eagercon.com>
Cc: Pierre Muller <muller@ics.u-strasbg.fr>, gdb-patches@sourceware.org
Subject: Re: Build-failure from [PATCH] Support for Xilinx MicroBlaze
Date: Fri, 16 Oct 2009 16:35:00 -0000	[thread overview]
Message-ID: <20091016163457.GH5272@adacore.com> (raw)
In-Reply-To: <4AD8978D.9080305@eagercon.com>

> 2009-10-16  Michael Eager  <eager@eagercon.com>
>
> 	* microblaze-linux-tdep.c:
> 	microblaze_linux_memory_remove_breakpoint(): Add gdbarch to param,
> 	replace frame_pc_unwind with get_frame_address_in_block.
> 	* microblaze-tdep.c: Remove MICROBLAZE_REGISTER_SIZE.
> 	* microblaze-tdep.h: Add MICROBLAZE_REGISTER_SIZE.

Approved.  For the future, patches fixing build failures of a target
can be treated as obvious unless you really think that a second pair
of eyes would be better.

-- 
Joel


  parent reply	other threads:[~2009-10-16 16:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 16:32 Michael Eager
2009-10-15 16:44 ` Tom Tromey
2009-10-15 16:47   ` Joel Brobecker
2009-10-15 18:00     ` Tom Tromey
2009-10-15 18:04       ` Tom Tromey
2009-10-15 18:31         ` Joel Brobecker
2009-10-16 12:53         ` Daniel Jacobowitz
2009-10-16 16:14           ` Michael Eager
2009-10-15 17:12   ` Michael Eager
2009-10-15 17:18     ` Joel Brobecker
2009-10-15 18:06       ` Michael Eager
2009-10-15 16:46 ` Joel Brobecker
2009-10-15 17:14   ` Michael Eager
2009-10-15 19:31   ` Michael Eager
2009-10-16  7:53     ` Build-failure from " Pierre Muller
2009-10-16 15:56       ` Michael Eager
2009-10-16 16:11         ` Pierre Muller
2009-10-16 16:35         ` Joel Brobecker [this message]
2009-10-16 23:21           ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091016163457.GH5272@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eager@eagercon.com \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox