From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24294 invoked by alias); 16 Oct 2009 16:35:08 -0000 Received: (qmail 24285 invoked by uid 22791); 16 Oct 2009 16:35:08 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Oct 2009 16:35:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 092112BAC6B; Fri, 16 Oct 2009 12:35:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mknWVsqIoJQa; Fri, 16 Oct 2009 12:35:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8A2612BAC02; Fri, 16 Oct 2009 12:35:00 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7D1A7F591F; Fri, 16 Oct 2009 09:34:57 -0700 (PDT) Date: Fri, 16 Oct 2009 16:35:00 -0000 From: Joel Brobecker To: Michael Eager Cc: Pierre Muller , gdb-patches@sourceware.org Subject: Re: Build-failure from [PATCH] Support for Xilinx MicroBlaze Message-ID: <20091016163457.GH5272@adacore.com> References: <4AD74E86.1020500@eagercon.com> <20091015164604.GB5272@adacore.com> <4AD77877.2050909@eagercon.com> <001501ca4e35$a9392c10$fbab8430$@u-strasbg.fr> <4AD8978D.9080305@eagercon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD8978D.9080305@eagercon.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00367.txt.bz2 > 2009-10-16 Michael Eager > > * microblaze-linux-tdep.c: > microblaze_linux_memory_remove_breakpoint(): Add gdbarch to param, > replace frame_pc_unwind with get_frame_address_in_block. > * microblaze-tdep.c: Remove MICROBLAZE_REGISTER_SIZE. > * microblaze-tdep.h: Add MICROBLAZE_REGISTER_SIZE. Approved. For the future, patches fixing build failures of a target can be treated as obvious unless you really think that a second pair of eyes would be better. -- Joel