Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] ia64: incorrect breakpoint save/restore with L-type  instruction at slot 1
Date: Tue, 29 Sep 2009 19:29:00 -0000	[thread overview]
Message-ID: <20090929192854.GA2548@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20090929191401.GC6362@adacore.com>

On Tue, 29 Sep 2009 21:14:01 +0200, Joel Brobecker wrote:
> > gdb/testsuite/
> > 2009-09-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	* gdb.base/breakpoint-shadow.exp: Move the ia64 part into ...
> > 	* gdb.arch/ia64-breakpoint-shadow.exp, ... a new file, with new tests.
> > 	* gdb.arch/ia64-breakpoint-shadow.S: New file.
> 
> Just one nit, I think. Shouldn't we disassemble bundle, rather than
> main?

I do not find any difference, whole `main' is supplied by the testcase, I do
not see any pros/cons of either of two.  Thanks for the review.


> Pre-approved, HEAD and branch.

Checked-in in the posted form:
	http://sourceware.org/ml/gdb-cvs/2009-09/msg00228.html
	http://sourceware.org/ml/gdb-cvs/2009-09/msg00229.html (gdb_7_0-branch)


Thanks,
Jan


  reply	other threads:[~2009-09-29 19:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25 20:48 Joel Brobecker
2009-09-26 21:57 ` Jan Kratochvil
2009-09-29  0:16   ` Joel Brobecker
2009-09-29  1:31     ` Joel Brobecker
2009-09-29 18:55     ` Jan Kratochvil
2009-09-29 19:14       ` Joel Brobecker
2009-09-29 19:29         ` Jan Kratochvil [this message]
2009-09-29  0:00 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090929192854.GA2548@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox