From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11123 invoked by alias); 29 Sep 2009 19:29:24 -0000 Received: (qmail 11112 invoked by uid 22791); 29 Sep 2009 19:29:24 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 19:29:20 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8TJSvt0015932; Tue, 29 Sep 2009 15:28:57 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8TJSt0p027270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Sep 2009 15:28:57 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n8TJSsdQ002628; Tue, 29 Sep 2009 21:28:54 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n8TJSs7u002627; Tue, 29 Sep 2009 21:28:54 +0200 Date: Tue, 29 Sep 2009 19:29:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] ia64: incorrect breakpoint save/restore with L-type instruction at slot 1 Message-ID: <20090929192854.GA2548@host0.dyn.jankratochvil.net> References: <20090925204835.GF5077@adacore.com> <20090926215709.GA26221@host0.dyn.jankratochvil.net> <20090929001641.GH9003@adacore.com> <20090929185518.GA598@host0.dyn.jankratochvil.net> <20090929191401.GC6362@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090929191401.GC6362@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00934.txt.bz2 On Tue, 29 Sep 2009 21:14:01 +0200, Joel Brobecker wrote: > > gdb/testsuite/ > > 2009-09-29 Jan Kratochvil > > > > * gdb.base/breakpoint-shadow.exp: Move the ia64 part into ... > > * gdb.arch/ia64-breakpoint-shadow.exp, ... a new file, with new tests. > > * gdb.arch/ia64-breakpoint-shadow.S: New file. > > Just one nit, I think. Shouldn't we disassemble bundle, rather than > main? I do not find any difference, whole `main' is supplied by the testcase, I do not see any pros/cons of either of two. Thanks for the review. > Pre-approved, HEAD and branch. Checked-in in the posted form: http://sourceware.org/ml/gdb-cvs/2009-09/msg00228.html http://sourceware.org/ml/gdb-cvs/2009-09/msg00229.html (gdb_7_0-branch) Thanks, Jan