From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Fix bitfield regressions on 64-bit big-endian targets
Date: Mon, 28 Sep 2009 16:33:00 -0000 [thread overview]
Message-ID: <20090928163349.GB1529@caradoc.them.org> (raw)
In-Reply-To: <200909280920.n8S9KVeK008925@d12av02.megacenter.de.ibm.com>
On Mon, Sep 28, 2009 at 11:20:31AM +0200, Ulrich Weigand wrote:
> Daniel Jacobowitz wrote:
>
> > It looks like the code you're fixing was completely bogus.
> >
> > > ! && ((LONGEST) value_address (toval) % TYPE_LENGTH (type)) == 0)
> >
> > What does that even mean? We set v->offset, both before and after the
> > patch you're replying to, but we never set value->location.address.
> > Are we only testing this in registers somehow where no address was
> > required? Or am I missing where the location was set?
>
> Well, it seems to me that value_primitive_field calls
> set_value_component_location in all cases, which copies
> the location information over to the new value ...
So it does. The representation I'm using here may not be
well-advised, in that case, but at least you've made us consistent
again.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-09-28 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 19:55 [commit] Fix bitfield errors - PR 10565 Daniel Jacobowitz
2009-09-27 21:48 ` [rfc] Fix bitfield regressions on 64-bit big-endian targets Ulrich Weigand
2009-09-27 22:28 ` Daniel Jacobowitz
2009-09-28 9:20 ` Ulrich Weigand
2009-09-28 16:33 ` Daniel Jacobowitz [this message]
2009-09-28 18:07 ` Joel Brobecker
2009-09-28 18:32 ` Daniel Jacobowitz
2009-09-29 0:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928163349.GB1529@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox