From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Fix bitfield regressions on 64-bit big-endian targets
Date: Mon, 28 Sep 2009 09:20:00 -0000 [thread overview]
Message-ID: <200909280920.n8S9KVeK008925@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20090927222844.GA32132@caradoc.them.org> from "Daniel Jacobowitz" at Sep 27, 2009 06:28:44 PM
Daniel Jacobowitz wrote:
> It looks like the code you're fixing was completely bogus.
>
> > ! && ((LONGEST) value_address (toval) % TYPE_LENGTH (type)) == 0)
>
> What does that even mean? We set v->offset, both before and after the
> patch you're replying to, but we never set value->location.address.
> Are we only testing this in registers somehow where no address was
> required? Or am I missing where the location was set?
Well, it seems to me that value_primitive_field calls
set_value_component_location in all cases, which copies
the location information over to the new value ...
In any case, the code you quote above was introduced by
your initial lazy bitfields patch:
http://sourceware.org/ml/gdb-patches/2009-07/msg00437.html
> Your patch looks fine to me.
Thanks for the review. I've committed the patch now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2009-09-28 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 19:55 [commit] Fix bitfield errors - PR 10565 Daniel Jacobowitz
2009-09-27 21:48 ` [rfc] Fix bitfield regressions on 64-bit big-endian targets Ulrich Weigand
2009-09-27 22:28 ` Daniel Jacobowitz
2009-09-28 9:20 ` Ulrich Weigand [this message]
2009-09-28 16:33 ` Daniel Jacobowitz
2009-09-28 18:07 ` Joel Brobecker
2009-09-28 18:32 ` Daniel Jacobowitz
2009-09-29 0:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909280920.n8S9KVeK008925@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox