Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>,
	 gdb-patches@sourceware.org,
	 Mark Kettenis <mark.kettenis@xs4all.nl>,
	 brobecker@adacore.com,  teawater@gmail.com,  msnyder@vmware.com
Subject: Re: [RFA] Check solib bfd arch
Date: Fri, 18 Sep 2009 16:41:00 -0000	[thread overview]
Message-ID: <200909181741.43702.pedro@codesourcery.com> (raw)
In-Reply-To: <20090918162511.GA25315@caradoc.them.org>

On Friday 18 September 2009 17:25:11, Daniel Jacobowitz wrote:

> A description can cover many areas, but is not required to cover any
> of them.  I don't think anything should rely on "is there a
> description".

Good point, although we could check if the description
included an arch.

> It does seem to me like the test should be symmetric here:
>   a = bfd_get_arch_info (abfd);
>   if (b->compatible (b, a) != b
>       && a->compatible (a, b) != a)

I think that's the same in practice as Joel's original
patch then, since `compatible' either returns either
NULL, a or b.  This still catches the
obviously-incompatible cases, so may be worth keeping,
while anything smarter is probably not worth the effort
then.

-- 
Pedro Alves


  reply	other threads:[~2009-09-18 16:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03  9:52 Hui Zhu
2009-07-05 21:36 ` Ulrich Weigand
2009-07-06  3:03   ` Hui Zhu
2009-07-07 16:45     ` Ulrich Weigand
2009-07-08  2:46       ` Hui Zhu
2009-07-09 13:43         ` Ulrich Weigand
2009-07-09 16:50           ` Hui Zhu
2009-09-17 22:56         ` Joel Brobecker
2009-09-18  5:05           ` Hui Zhu
2009-09-18 12:50           ` Ulrich Weigand
2009-09-18 13:06             ` Ulrich Weigand
2009-09-18 13:10             ` Daniel Jacobowitz
2009-09-18 14:24               ` Joel Brobecker
2009-09-18 14:08             ` Mark Kettenis
2009-09-18 14:11               ` Mark Kettenis
2009-09-18 14:39               ` Daniel Jacobowitz
2009-09-18 14:53                 ` Pedro Alves
2009-09-18 16:14                   ` Ulrich Weigand
2009-09-18 16:25                     ` Daniel Jacobowitz
2009-09-18 16:41                       ` Pedro Alves [this message]
2009-09-18 16:44                         ` Daniel Jacobowitz
2009-09-18 16:45                         ` Pedro Alves
2009-09-18 17:17                           ` Joel Brobecker
2009-09-18 20:43                             ` Joel Brobecker
2009-09-22 23:04           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909181741.43702.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox