[RFA] Fix "show convenience" test

["Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1093 bytes --]

Hi guys,

This is a simple one.  After running GDB's testsuite, I saw that one of the 
gdb.base/default.exp's tests was not passing.  It tested the output of the 
"show convenience" command.

After a little investigation, it seems that:

http://sourceware.org/ml/gdb-patches/2009-02/msg00165.html

Is the responsible for this, since this patch was creating an internal 
convenience variable ($_siginfo) which appears in the "show convenience" 
command, while the original test expects to receive a warning saying that no 
convenience variable is created at the moment.  If I understood the patch 
correctly, the $_siginfo will be always created and therefore the test should 
now expect "$_siginfo = void" instead of this warning.  Am I missing 
something?

Regards,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil

gdb/testsuite/ChangeLog:

2009-09-15  Sergio Durigan Junior <sergiosdj@gmail.com>

	* gdb.base/default.exp: Updated the "show convenience" test
	in order to accept the new output.

[-- Attachment #2: show-convenience.patch --]
[-- Type: text/x-patch, Size: 900 bytes --]

diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
index a223982..a0cb11e 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -598,7 +598,7 @@ gdb_test "show complaints" "Max number of complaints about incorrect symbols is
 #test show confirm
 gdb_test "show confirm" "Whether to confirm potentially dangerous operations is o\[a-z\]*." "show confirm"
 #test show convenience
-gdb_test "show convenience" "No debugger convenience variables now defined.(\[^\r\n\]*\[\r\n\])+Convenience variables have names starting with \".\";(\[^\r\n\]*\[\r\n\])+use \"set\" as in \"set .foo = 5\" to define them." "show convenience"
+gdb_test "show convenience" "\\\$_siginfo = void" "show convenience"
 #test show directories
 gdb_test "show directories" "Source directories searched: .cdir\[:;\].cwd" "show directories"
 #test show editing