From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3822 invoked by alias); 16 Sep 2009 00:32:33 -0000 Received: (qmail 3814 invoked by uid 22791); 16 Sep 2009 00:32:32 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Sep 2009 00:32:28 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp05.br.ibm.com (8.14.3/8.13.1) with ESMTP id n8G0T3Ul019603 for ; Tue, 15 Sep 2009 21:29:03 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8G0X4QM1396836 for ; Tue, 15 Sep 2009 21:33:04 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8G0WKcD019859 for ; Tue, 15 Sep 2009 21:32:24 -0300 Received: from miki.localnet ([9.8.11.232]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n8G0WHxr019793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Sep 2009 21:32:18 -0300 From: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= To: gdb-patches@sourceware.org Subject: [RFA] Fix "show convenience" test Date: Wed, 16 Sep 2009 00:32:00 -0000 User-Agent: KMail/1.12.1 (Linux/2.6.30.4; KDE/4.3.1; i686; ; ) Cc: Pedro Alves MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_PIDsKatgWITX8ri" Message-Id: <200909152132.15317.sergiodj@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00496.txt.bz2 --Boundary-00=_PIDsKatgWITX8ri Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1093 Hi guys, This is a simple one. After running GDB's testsuite, I saw that one of the= =20 gdb.base/default.exp's tests was not passing. It tested the output of the= =20 "show convenience" command. After a little investigation, it seems that: http://sourceware.org/ml/gdb-patches/2009-02/msg00165.html Is the responsible for this, since this patch was creating an internal=20 convenience variable ($_siginfo) which appears in the "show convenience"=20 command, while the original test expects to receive a warning saying that n= o=20 convenience variable is created at the moment. If I understood the patch=20 correctly, the $_siginfo will be always created and therefore the test shou= ld=20 now expect "$_siginfo =3D void" instead of this warning. Am I missing=20 something? Regards, --=20 S=E9rgio Durigan J=FAnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil gdb/testsuite/ChangeLog: 2009-09-15 Sergio Durigan Junior * gdb.base/default.exp: Updated the "show convenience" test in order to accept the new output. --Boundary-00=_PIDsKatgWITX8ri Content-Type: text/x-patch; charset="ISO-8859-1"; name="show-convenience.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="show-convenience.patch" Content-length: 900 diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index a223982..a0cb11e 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -598,7 +598,7 @@ gdb_test "show complaints" "Max number of complaints about incorrect symbols is #test show confirm gdb_test "show confirm" "Whether to confirm potentially dangerous operations is o\[a-z\]*." "show confirm" #test show convenience -gdb_test "show convenience" "No debugger convenience variables now defined.(\[^\r\n\]*\[\r\n\])+Convenience variables have names starting with \".\";(\[^\r\n\]*\[\r\n\])+use \"set\" as in \"set .foo = 5\" to define them." "show convenience" +gdb_test "show convenience" "\\\$_siginfo = void" "show convenience" #test show directories gdb_test "show directories" "Source directories searched: .cdir\[:;\].cwd" "show directories" #test show editing --Boundary-00=_PIDsKatgWITX8ri--