From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [commit] Fix intermittent failures in breakpoint-shadow.exp.
Date: Thu, 10 Sep 2009 22:34:00 -0000 [thread overview]
Message-ID: <20090910223357.D1A62843B9@localhost> (raw)
Hi.
I got a failure in breakpoint-shadow.exp.
gdb.log has this:
(gdb) PASS: gdb.base/breakpoint-shadow.exp: First breakpoint placed
b 24
Breakpoint 3 at 0x400397: file ../../../../src/gdb/testsuite/gdb.base/breakpoint-shadow.c, line 24.
PASS: gdb.base/breakpoint-shadow.exp: Second breakpoint placed
disass main
(gdb) FAIL: gdb.base/breakpoint-shadow.exp: disassembly with breakpoints
testcase ../../../../src/gdb/testsuite/gdb.base/breakpoint-shadow.exp completed in 1 seconds
Notice that the "disass main" command seemingly has no output.
Also note that there is no gdb prompt between the "b 24" command
and the "disass main" command.
The regexp for placing the second breakpoint needs to include
the gdb prompt (otherwise a regexp internal to gdb_test_multiple may
see it and prematurely return).
Checked in.
2009-09-10 Doug Evans <dje@google.com>
* gdb.base/breakpoint-shadow.exp: Fix intermittent failures.
Add $gdb_prompt to second breakpoint regexp.
Index: testsuite/gdb.base/breakpoint-shadow.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/breakpoint-shadow.exp,v
retrieving revision 1.3
diff -u -p -r1.3 breakpoint-shadow.exp
--- testsuite/gdb.base/breakpoint-shadow.exp 8 Sep 2009 17:39:22 -0000 1.3
+++ testsuite/gdb.base/breakpoint-shadow.exp 10 Sep 2009 22:23:46 -0000
@@ -50,7 +50,7 @@ gdb_test_multiple "disass main" $test {
gdb_test "b [gdb_get_line_number "break-first"]" "Breakpoint \[0-9\] at .*" "First breakpoint placed"
set test "Second breakpoint placed"
gdb_test_multiple "b [gdb_get_line_number "break-second"]" $test {
- -re "Breakpoint \[0-9\] at (0x\[0-9a-f\]*):.*" {
+ -re "Breakpoint \[0-9\] at (0x\[0-9a-f\]*):.*$gdb_prompt $" {
pass $test
set bpt2address $expect_out(1,string)
}
next reply other threads:[~2009-09-10 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 22:34 Doug Evans [this message]
2009-09-11 7:58 ` Jan Kratochvil
2009-09-11 15:22 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910223357.D1A62843B9@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox