From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22224 invoked by alias); 10 Sep 2009 22:34:09 -0000 Received: (qmail 22216 invoked by uid 22791); 10 Sep 2009 22:34:09 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Sep 2009 22:34:03 +0000 Received: from spaceape13.eur.corp.google.com (spaceape13.eur.corp.google.com [172.28.16.147]) by smtp-out.google.com with ESMTP id n8AMY0kL017337 for ; Thu, 10 Sep 2009 23:34:00 +0100 Received: from localhost (ruffy.mtv.corp.google.com [172.18.118.116]) by spaceape13.eur.corp.google.com with ESMTP id n8AMXwsj007799 for ; Thu, 10 Sep 2009 15:33:58 -0700 Received: by localhost (Postfix, from userid 67641) id D1A62843B9; Thu, 10 Sep 2009 15:33:57 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [commit] Fix intermittent failures in breakpoint-shadow.exp. Message-Id: <20090910223357.D1A62843B9@localhost> Date: Thu, 10 Sep 2009 22:34:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00290.txt.bz2 Hi. I got a failure in breakpoint-shadow.exp. gdb.log has this: (gdb) PASS: gdb.base/breakpoint-shadow.exp: First breakpoint placed b 24 Breakpoint 3 at 0x400397: file ../../../../src/gdb/testsuite/gdb.base/breakpoint-shadow.c, line 24. PASS: gdb.base/breakpoint-shadow.exp: Second breakpoint placed disass main (gdb) FAIL: gdb.base/breakpoint-shadow.exp: disassembly with breakpoints testcase ../../../../src/gdb/testsuite/gdb.base/breakpoint-shadow.exp completed in 1 seconds Notice that the "disass main" command seemingly has no output. Also note that there is no gdb prompt between the "b 24" command and the "disass main" command. The regexp for placing the second breakpoint needs to include the gdb prompt (otherwise a regexp internal to gdb_test_multiple may see it and prematurely return). Checked in. 2009-09-10 Doug Evans * gdb.base/breakpoint-shadow.exp: Fix intermittent failures. Add $gdb_prompt to second breakpoint regexp. Index: testsuite/gdb.base/breakpoint-shadow.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/breakpoint-shadow.exp,v retrieving revision 1.3 diff -u -p -r1.3 breakpoint-shadow.exp --- testsuite/gdb.base/breakpoint-shadow.exp 8 Sep 2009 17:39:22 -0000 1.3 +++ testsuite/gdb.base/breakpoint-shadow.exp 10 Sep 2009 22:23:46 -0000 @@ -50,7 +50,7 @@ gdb_test_multiple "disass main" $test { gdb_test "b [gdb_get_line_number "break-first"]" "Breakpoint \[0-9\] at .*" "First breakpoint placed" set test "Second breakpoint placed" gdb_test_multiple "b [gdb_get_line_number "break-second"]" $test { - -re "Breakpoint \[0-9\] at (0x\[0-9a-f\]*):.*" { + -re "Breakpoint \[0-9\] at (0x\[0-9a-f\]*):.*$gdb_prompt $" { pass $test set bpt2address $expect_out(1,string) }