From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
gdb-patches@sourceware.org, bonzini@gnu.org
Subject: Re: obtaining configure args from config.status
Date: Tue, 08 Sep 2009 18:51:00 -0000 [thread overview]
Message-ID: <20090908185136.GB21719@gmx.de> (raw)
In-Reply-To: <m3ws49wacs.fsf@fleche.redhat.com>
* Tom Tromey wrote on Tue, Sep 08, 2009 at 08:38:11PM CEST:
> >>>>> "Ralf" == Ralf Wildenhues writes:
>
> >> eval $(SHELL) $${rootsrc}/testsuite/configure "$$configargs" \
> >> --srcdir=\$${rootsrc}/testsuite \
> >> Other parts of Makefile.in already cannot cope with spaces in $srcdir.
>
> Ralf> True. The quoting also avoids globbing, though, so I've become used to
> Ralf> using it consistently, also because many other packages do cope with
> Ralf> spaces in the absolute directory name, as long as $srcdir is relative
> Ralf> and doesn't contain any spaces. But hey, if it's desired, I'll gladly
> Ralf> change the patch as above.
>
> If it doesn't hurt anything (other than readability), it is ok to leave
> it as you have it.
Yes, it should not hurt. Thanks for the review, applied.
prev parent reply other threads:[~2009-09-08 18:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090628183334.GA5401@gmx.de>
2009-07-28 18:54 ` Update rebuild rules in non-automake directories Ralf Wildenhues
2009-07-28 19:51 ` Paolo Bonzini
2009-07-28 21:35 ` Tom Tromey
2009-07-29 3:09 ` Samuel Bronson
2009-07-29 5:31 ` Tom Tromey
2009-07-29 16:15 ` Ralf Wildenhues
2009-07-29 18:35 ` Samuel Bronson
2009-07-29 18:37 ` Tom Tromey
2009-07-30 21:27 ` Ralf Wildenhues
[not found] ` <20090730210952.GD24465__15749.4424529888$1248988226$gmane$org@gmx.de>
2009-07-30 21:30 ` Tom Tromey
2009-07-29 15:16 ` Ben Elliston
2009-08-26 16:29 ` Jan Kratochvil
2009-08-26 16:54 ` Ralf Wildenhues
2009-08-26 17:10 ` Jan Kratochvil
2009-08-26 17:51 ` Ralf Wildenhues
2009-08-26 17:57 ` Eli Zaretskii
2009-08-26 19:13 ` Jan Kratochvil
2009-08-31 20:42 ` obtaining configure args from config.status (was: Update rebuild rules in non-automake directories.) Ralf Wildenhues
2009-09-01 1:10 ` obtaining configure args from config.status Paolo Bonzini
2009-09-06 18:15 ` obtaining configure args from config.status (was: Update rebuild rules in non-automake directories.) Ralf Wildenhues
2009-09-08 18:37 ` obtaining configure args from config.status Tom Tromey
2009-09-08 16:28 ` Jan Kratochvil
2009-09-08 18:26 ` Ralf Wildenhues
2009-09-08 18:38 ` Tom Tromey
2009-09-08 18:51 ` Ralf Wildenhues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908185136.GB21719@gmx.de \
--to=ralf.wildenhues@gmx.de \
--cc=bonzini@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox