From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6424 invoked by alias); 8 Sep 2009 18:51:57 -0000 Received: (qmail 6388 invoked by uid 22791); 8 Sep 2009 18:51:56 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 08 Sep 2009 18:51:44 +0000 Received: (qmail invoked by alias); 08 Sep 2009 18:51:38 -0000 Received: from xdsl-87-79-132-28.netcologne.de (EHLO localhost.localdomain) [87.79.132.28] by mail.gmx.net (mp042) with SMTP; 08 Sep 2009 20:51:38 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1Ml5my-0005fj-Jr; Tue, 08 Sep 2009 20:51:36 +0200 Date: Tue, 08 Sep 2009 18:51:00 -0000 From: Ralf Wildenhues To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org, bonzini@gnu.org Subject: Re: obtaining configure args from config.status Message-ID: <20090908185136.GB21719@gmx.de> References: <20090628183334.GA5401@gmx.de> <20090728181748.GA3134@gmx.de> <20090826151719.GA22276@host0.dyn.jankratochvil.net> <20090826164636.GA15791@ins.uni-bonn.de> <20090826165410.GA28796@host0.dyn.jankratochvil.net> <20090831202938.GC21485@gmx.de> <20090908162826.GA31394@host0.dyn.jankratochvil.net> <20090908182614.GC13584@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00215.txt.bz2 * Tom Tromey wrote on Tue, Sep 08, 2009 at 08:38:11PM CEST: > >>>>> "Ralf" == Ralf Wildenhues writes: > > >> eval $(SHELL) $${rootsrc}/testsuite/configure "$$configargs" \ > >> --srcdir=\$${rootsrc}/testsuite \ > >> Other parts of Makefile.in already cannot cope with spaces in $srcdir. > > Ralf> True. The quoting also avoids globbing, though, so I've become used to > Ralf> using it consistently, also because many other packages do cope with > Ralf> spaces in the absolute directory name, as long as $srcdir is relative > Ralf> and doesn't contain any spaces. But hey, if it's desired, I'll gladly > Ralf> change the patch as above. > > If it doesn't hurt anything (other than readability), it is ok to leave > it as you have it. Yes, it should not hurt. Thanks for the review, applied.