Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [RFA/PATCH] PR/9711: quadratic slowdown for deep stack traces
Date: Mon, 07 Sep 2009 23:12:00 -0000	[thread overview]
Message-ID: <20090907231213.GM30677@adacore.com> (raw)
In-Reply-To: <200909072321.12505.pedro@codesourcery.com>

> Fine with me, although I wouldn't mind a reference to which is the
> the "another function" talked about here (--- my thinking is that it
> should be "easy" to get here when touching the problematic caller in
> question.  If it is grep-easy, the merrier.  If the reference in the
> comment ends up out-of-date at some point, then it just means the
> that a good time to rethink the stash as been
> reached).   Just a "(see foo_func)" would be fine.  Anyway, thanks!

I usually am not a big fan of putting references to other calling
functions inside comments, but I don't mind much. New version attached.
I am hoping to commit this on Wednesday (still hoping that we have
every blocking item dealt with by then, although it looks like it's
going to be a bit of a stretch).

-- 
Joel


  reply	other threads:[~2009-09-07 23:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 18:37 Joel Brobecker
2009-09-03 20:27 ` Tom Tromey
2009-09-07  7:30 ` Doug Evans
2009-09-07 20:33   ` Joel Brobecker
2009-09-07 20:48     ` Doug Evans
2009-09-07 20:57     ` Pedro Alves
2009-09-07 22:00       ` Joel Brobecker
2009-09-07 22:21         ` Pedro Alves
2009-09-07 23:12           ` Joel Brobecker [this message]
2009-09-08  0:06             ` Joel Brobecker
2009-09-09 17:39               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090907231213.GM30677@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox