From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>, Doug Evans <dje@google.com>
Subject: Re: [RFA/PATCH] PR/9711: quadratic slowdown for deep stack traces
Date: Mon, 07 Sep 2009 20:57:00 -0000 [thread overview]
Message-ID: <200909072156.53133.pedro@codesourcery.com> (raw)
In-Reply-To: <20090907203321.GI30677@adacore.com>
On Monday 07 September 2009 21:33:21, Joel Brobecker wrote:
> > Nit: It seems like there's a redundant call to frame_id_eq in frame_find_by_id.
>
> Ooops, you're right. Thanks for catching this! Here is a new patch.
> I used "frame_stash" to avoid the confusion with the "cache" terminology
> used in that unit.
>
> Currently testing on x86_64-linux...
>
Hmmm, nowhere in the patch is the actual reason this is
needed explained. Could you have some of that?
+ /* Try using the frame cache first. */
+ frame = frame_stash_find (id);
+ if (frame)
+ return frame;
I guess here would be a good place to explain it. At least update
the comment to refer to stash instead of cache. :-)
--
Pedro Alves
next prev parent reply other threads:[~2009-09-07 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 18:37 Joel Brobecker
2009-09-03 20:27 ` Tom Tromey
2009-09-07 7:30 ` Doug Evans
2009-09-07 20:33 ` Joel Brobecker
2009-09-07 20:48 ` Doug Evans
2009-09-07 20:57 ` Pedro Alves [this message]
2009-09-07 22:00 ` Joel Brobecker
2009-09-07 22:21 ` Pedro Alves
2009-09-07 23:12 ` Joel Brobecker
2009-09-08 0:06 ` Joel Brobecker
2009-09-09 17:39 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909072156.53133.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox