Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: Pierre Muller <muller@ics.u-strasbg.fr>,
	jules@sourceware.org, 	gdb-patches@sourceware.org
Subject: Re: [ARI regression] in  arm-tdep.c
Date: Thu, 03 Sep 2009 18:53:00 -0000	[thread overview]
Message-ID: <20090903185326.GD4365@adacore.com> (raw)
In-Reply-To: <1251993692.12941.0.camel@e200601-lin.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

(thanks Pierre for bringing this issue up!)

> OK, though I think "Invalid argument to displaced_write_reg" might be a
> better error.

Just to help speed things up, here is what I checked in:

2009-09-03  Pierre Muller <muller@ics.u-strasbg.fr>
            Richard Earnshaw <rearnsha@arm.com>

        * arm-tdep.c (displaced_write_reg): Replace call to abort by call
        to internal_error.

Tested by recompiling arm-tdep.c only.

-- 
Joel

[-- Attachment #2: arm-tdep.diff --]
[-- Type: text/x-diff, Size: 500 bytes --]

Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.286
diff -u -p -r1.286 arm-tdep.c
--- arm-tdep.c	14 Aug 2009 00:32:31 -0000	1.286
+++ arm-tdep.c	3 Sep 2009 18:49:55 -0000
@@ -2769,7 +2769,8 @@ displaced_write_reg (struct regcache *re
 	  break;
 
 	default:
-	  abort ();
+	  internal_error (__FILE__, __LINE__,
+			  _("Invalid argument to displaced_write_reg"));
 	}
 
       dsc->wrote_to_pc = 1;

      reply	other threads:[~2009-09-03 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090730230505.22710.qmail@sourceware.org>
2009-09-03  8:11 ` Pierre Muller
2009-09-03 16:01   ` Richard Earnshaw
2009-09-03 18:53     ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090903185326.GD4365@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jules@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox