From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3667 invoked by alias); 3 Sep 2009 18:53:43 -0000 Received: (qmail 3645 invoked by uid 22791); 3 Sep 2009 18:53:42 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Sep 2009 18:53:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 789432BAB1B; Thu, 3 Sep 2009 14:53:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AOH4DnJqXOru; Thu, 3 Sep 2009 14:53:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 351362BAAE9; Thu, 3 Sep 2009 14:53:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9D512F589A; Thu, 3 Sep 2009 11:53:26 -0700 (PDT) Date: Thu, 03 Sep 2009 18:53:00 -0000 From: Joel Brobecker To: Richard Earnshaw Cc: Pierre Muller , jules@sourceware.org, gdb-patches@sourceware.org Subject: Re: [ARI regression] in arm-tdep.c Message-ID: <20090903185326.GD4365@adacore.com> References: <20090730230505.22710.qmail@sourceware.org> <001001ca2c6e$294c4750$7be4d5f0$@u-strasbg.fr> <1251993692.12941.0.camel@e200601-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <1251993692.12941.0.camel@e200601-lin.cambridge.arm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00088.txt.bz2 --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 446 (thanks Pierre for bringing this issue up!) > OK, though I think "Invalid argument to displaced_write_reg" might be a > better error. Just to help speed things up, here is what I checked in: 2009-09-03 Pierre Muller Richard Earnshaw * arm-tdep.c (displaced_write_reg): Replace call to abort by call to internal_error. Tested by recompiling arm-tdep.c only. -- Joel --jRHKVT23PllUwdXP Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="arm-tdep.diff" Content-length: 500 Index: arm-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/arm-tdep.c,v retrieving revision 1.286 diff -u -p -r1.286 arm-tdep.c --- arm-tdep.c 14 Aug 2009 00:32:31 -0000 1.286 +++ arm-tdep.c 3 Sep 2009 18:49:55 -0000 @@ -2769,7 +2769,8 @@ displaced_write_reg (struct regcache *re break; default: - abort (); + internal_error (__FILE__, __LINE__, + _("Invalid argument to displaced_write_reg")); } dsc->wrote_to_pc = 1; --jRHKVT23PllUwdXP--