[RFA] Rename python files.

[RFA] Rename python files.

[Thiago Jung Bauermann]

[-- Attachment #1: Type: Text/Plain, Size: 1794 bytes --]

Hi,

Eli asked that the source code and testcase files pertaining to python 
scripting support be renamed in order to support the 8.3 limitation in DOS. I
don't like the fnchange.lst solution because it's just one more arcane thing 
we would have to know in order to hack GDB. So I prefer straight renaming of 
the files.

How should said renaming be done, by submitting and committing a patch which 
removes the old file and adds a new one, or by moving things around in CVSROOT?

In any case, this is my suggestion for the source code files:

python/python-cmd.c -> python/py-cmd.c
python/python-frame.c -> python/py-frame.c
python/python-function.c -> python/py-function.c
python/python-prettyprint.c -> python/py-prettyprint.c
python/python-type.c -> python/py-type.c
python/python-utils.c -> python/py-utils.c
python/python-value.c -> python/py-value.c

and the testcase files:

gdb.python/python-cmd.exp -> gdb.python/py-cmd.exp
gdb.python/python-frame.c -> gdb.python/py-frame.c
gdb.python/python-frame.exp -> gdb.python/py-frame.exp
gdb.python/python-function.exp -> gdb.python/py-function.exp
gdb.python/python-mi.exp -> gdb.python/py-mi.exp
gdb.python/python-prettyprint.c -> gdb.python/py-prettyprint.c
gdb.python/python-prettyprint.exp -> gdb.python/py-prettyprint.exp
gdb.python/python-prettyprint.py -> gdb.python/py-prettyprint.py
gdb.python/python-template.cc -> gdb.python/py-template.cc
gdb.python/python-template.exp -> gdb.python/py-template.exp
gdb.python/python-value.c -> gdb.python/py-value.c
gdb.python/python-value.exp -> gdb.python/py-value.exp

I'll write changelogs before committing anything, of course.

I also have the two attached patches to adapt Makefile.in and the various test 
files (for the new test executable names).

Ok?
-- 
[]'s
Thiago Jung Bauermann

[-- Attachment #2: submit-code-partial.diff --]
[-- Type: text/x-patch, Size: 3014 bytes --]

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index ccc4db8..82ffce8 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -264,24 +264,24 @@ SUBDIR_TUI_CFLAGS= \
 #
 SUBDIR_PYTHON_OBS = \
 	python.o \
-	python-cmd.o \
-	python-frame.o \
-	python-function.o \
-	python-objfile.o \
-	python-prettyprint.o \
-	python-type.o \
-	python-utils.o \
-	python-value.o
+	py-cmd.o \
+	py-frame.o \
+	py-function.o \
+	py-objfile.o \
+	py-prettyprint.o \
+	py-type.o \
+	py-utils.o \
+	py-value.o
 SUBDIR_PYTHON_SRCS = \
 	python/python.c \
-	python/python-cmd.c \
-	python/python-frame.c \
-	python/python-function.c \
-	python/python-objfile.c \
-	python/python-prettyprint.c \
-	python/python-type.c \
-	python/python-utils.c \
-	python/python-value.c
+	python/py-cmd.c \
+	python/py-frame.c \
+	python/py-function.c \
+	python/py-objfile.c \
+	python/py-prettyprint.c \
+	python/py-type.c \
+	python/py-utils.c \
+	python/py-value.c
 SUBDIR_PYTHON_DEPS =
 SUBDIR_PYTHON_LDFLAGS=
 SUBDIR_PYTHON_CFLAGS=
@@ -1918,36 +1918,36 @@ python.o: $(srcdir)/python/python.c
 	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python.c
 	$(POSTCOMPILE)
 
-python-cmd.o: $(srcdir)/python/python-cmd.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-cmd.c
+py-cmd.o: $(srcdir)/python/py-cmd.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-cmd.c
 	$(POSTCOMPILE)
 
-python-frame.o: $(srcdir)/python/python-frame.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-frame.c
+py-frame.o: $(srcdir)/python/py-frame.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-frame.c
 	$(POSTCOMPILE)
 
-python-function.o: $(srcdir)/python/python-function.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-function.c
+py-function.o: $(srcdir)/python/py-function.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-function.c
 	$(POSTCOMPILE)
 
-python-objfile.o: $(srcdir)/python/python-objfile.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-objfile.c
+py-objfile.o: $(srcdir)/python/py-objfile.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-objfile.c
 	$(POSTCOMPILE)
 
-python-prettyprint.o: $(srcdir)/python/python-prettyprint.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-prettyprint.c
+py-prettyprint.o: $(srcdir)/python/py-prettyprint.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-prettyprint.c
 	$(POSTCOMPILE)
 
-python-type.o: $(srcdir)/python/python-type.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-type.c
+py-type.o: $(srcdir)/python/py-type.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-type.c
 	$(POSTCOMPILE)
 
-python-utils.o: $(srcdir)/python/python-utils.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-utils.c
+py-utils.o: $(srcdir)/python/py-utils.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-utils.c
 	$(POSTCOMPILE)
 
-python-value.o: $(srcdir)/python/python-value.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-value.c
+py-value.o: $(srcdir)/python/py-value.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-value.c
 	$(POSTCOMPILE)
 
 #

[-- Attachment #3: submit-testsuite-exp.diff --]
[-- Type: text/x-patch, Size: 3210 bytes --]

diff --git a/gdb/testsuite/gdb.python/Makefile.in b/gdb/testsuite/gdb.python/Makefile.in
index c49f713..655e604 100644
--- a/gdb/testsuite/gdb.python/Makefile.in
+++ b/gdb/testsuite/gdb.python/Makefile.in
@@ -1,7 +1,7 @@
 VPATH = @srcdir@
 srcdir = @srcdir@
 
-EXECUTABLES = python-value python-prettyprint python-template
+EXECUTABLES = py-value py-prettyprint py-template
 
 all info install-info dvi install uninstall installcheck check:
 	@echo "Nothing to be done for $@..."
diff --git a/gdb/testsuite/gdb.python//py-frame.exp b/gdb/testsuite/gdb.python//py-frame.exp
index 82ae814..13af0ba 100644
--- a/gdb/testsuite/gdb.python//py-frame.exp
+++ b/gdb/testsuite/gdb.python//py-frame.exp
@@ -31,7 +31,7 @@ if ![python_supported] then {
   return -1
 }
 
-set testfile "python-frame"
+set testfile "py-frame"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 
diff --git a/gdb/testsuite/gdb.python//py-mi.exp b/gdb/testsuite/gdb.python//py-mi.exp
index e7bfe54..ee000f1 100644
--- a/gdb/testsuite/gdb.python//py-mi.exp
+++ b/gdb/testsuite/gdb.python//py-mi.exp
@@ -24,7 +24,7 @@ if [mi_gdb_start] {
     continue
 }
 
-set testfile "python-prettyprint"
+set testfile "py-prettyprint"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DMI}] != "" } {
diff --git a/gdb/testsuite/gdb.python//py-prettyprint.exp b/gdb/testsuite/gdb.python//py-prettyprint.exp
index b2dc85d..2134ab9 100644
--- a/gdb/testsuite/gdb.python//py-prettyprint.exp
+++ b/gdb/testsuite/gdb.python//py-prettyprint.exp
@@ -20,7 +20,7 @@ if $tracelevel then {
     strace $tracelevel
 }
 
-set testfile "python-prettyprint"
+set testfile "py-prettyprint"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 
diff --git a/gdb/testsuite/gdb.python//py-template.exp b/gdb/testsuite/gdb.python//py-template.exp
index b80f56e..2d76371 100644
--- a/gdb/testsuite/gdb.python//py-template.exp
+++ b/gdb/testsuite/gdb.python//py-template.exp
@@ -31,7 +31,7 @@ if ![python_supported] then {
   return -1
 }
 
-set testfile "python-template"
+set testfile "py-template"
 set srcfile ${testfile}.cc
 set binfile ${objdir}/${subdir}/${testfile}
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
diff --git a/gdb/testsuite/gdb.python//py-value.exp b/gdb/testsuite/gdb.python//py-value.exp
index ccf438f..a4f58af 100644
--- a/gdb/testsuite/gdb.python//py-value.exp
+++ b/gdb/testsuite/gdb.python//py-value.exp
@@ -220,7 +220,7 @@ proc test_value_in_inferior {} {
 
 # A few objfile tests.
 proc test_objfiles {} {
-    gdb_test "python\nok=False\nfor file in gdb.objfiles():\n  if 'python-value' in file.filename:\n    ok=True\nprint ok\nend" "True"
+    gdb_test "python\nok=False\nfor file in gdb.objfiles():\n  if 'py-value' in file.filename:\n    ok=True\nprint ok\nend" "True"
 
     gdb_test "python print gdb.objfiles()\[0\].pretty_printers" "\\\[\\\]"
 
@@ -275,7 +275,7 @@ if ![python_supported] then {
   return -1
 }
 
-set testfile "python-value"
+set testfile "py-value"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 

Re: [RFA] Rename python files.

[Eli Zaretskii]

> From: Thiago Jung Bauermann <thiago.bauermann@gmail.com>
> Date: Thu, 13 Aug 2009 23:59:31 -0300
> 
> Eli asked that the source code and testcase files pertaining to python 
> scripting support be renamed in order to support the 8.3 limitation in DOS. I
> don't like the fnchange.lst solution because it's just one more arcane thing 
> we would have to know in order to hack GDB. So I prefer straight renaming of 
> the files.

Thanks.  I prefer renaming also, especially for files that (I hope)
will be compiled in the DJGPP port of GDB.  fnchange.lst is the last
resort, and using it is tricky for files that are actually compiled.

> How should said renaming be done, by submitting and committing a patch which 
> removes the old file and adds a new one, or by moving things around in CVSROOT?

The latter is better, because it preserves the CVS history.  But I
think it requires special privileges on the repository.

Re: [RFA] Rename python files.

[Matt Rice]

On Fri, Aug 14, 2009 at 12:11 AM, Eli Zaretskii<eliz@gnu.org> wrote:
>
>> How should said renaming be done, by submitting and committing a patch which
>> removes the old file and adds a new one, or by moving things around in CVSROOT?
>
> The latter is better, because it preserves the CVS history.  But I
> think it requires special privileges on the repository.
>

fyi I believe that by moving things around in the CVSROOT the changes
will not be automatically picked by the cvs/git conversion.

Re: [RFA] Rename python files.

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Thiago Jung Bauermann <thiago.bauermann@gmail.com>
>> Date: Thu, 13 Aug 2009 23:59:31 -0300
>> 
>> How should said renaming be done, by submitting and committing a patch which 
>> removes the old file and adds a new one, or by moving things around in CVSROOT?
>
> The latter is better, because it preserves the CVS history.

To the contrary, it will break the CVS history.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

Re: [RFA] Rename python files.

[Thiago Jung Bauermann]

Em Terça-feira 25 Agosto 2009 12:28:17 Matt Rice escreveu:
> On Fri, Aug 14, 2009 at 12:11 AM, Eli Zaretskii<eliz@gnu.org> wrote:
> >> How should said renaming be done, by submitting and committing a patch
> >> which removes the old file and adds a new one, or by moving things
> >> around in CVSROOT?
> >
> > The latter is better, because it preserves the CVS history.  But I
> > think it requires special privileges on the repository.
>
> fyi I believe that by moving things around in the CVSROOT the changes
> will not be automatically picked by the cvs/git conversion.

I don't know much about conversions from CVS so I'll take your word on it. A 
quick search on the interwebs seem to indicate that conversion tools aren't 
good about detecting renames anyway, since CVS doesn't support the operation.

IMHO the best way to do it then is to use the CVS-friendly way of doing a 
"rename": cvs rm $FILE, cvs add $NEW_FILE. IUUC git would be able to detect 
such rename (though I don't know it would show up in an svn-converted repo).

Ok if I do it that way?
-- 
[]'s
Thiago Jung Bauermann

Re: [RFA] Rename python files.

[Matt Rice]

On Sat, Aug 29, 2009 at 9:13 AM, Thiago Jung
Bauermann<thiago.bauermann@gmail.com> wrote:
> Em Terça-feira 25 Agosto 2009 12:28:17 Matt Rice escreveu:
>> On Fri, Aug 14, 2009 at 12:11 AM, Eli Zaretskii<eliz@gnu.org> wrote:
>> >> How should said renaming be done, by submitting and committing a patch
>> >> which removes the old file and adds a new one, or by moving things
>> >> around in CVSROOT?
>> >
>> > The latter is better, because it preserves the CVS history.  But I
>> > think it requires special privileges on the repository.
>>
>> fyi I believe that by moving things around in the CVSROOT the changes
>> will not be automatically picked by the cvs/git conversion.
>
> I don't know much about conversions from CVS so I'll take your word on it. A
> quick search on the interwebs seem to indicate that conversion tools aren't
> good about detecting renames anyway, since CVS doesn't support the operation.
>
> IMHO the best way to do it then is to use the CVS-friendly way of doing a
> "rename": cvs rm $FILE, cvs add $NEW_FILE. IUUC git would be able to detect
> such rename (though I don't know it would show up in an svn-converted repo).

Yeah, i'm really not familiar with conversions or monkeying with CVS
under the hood either,
only been on the losing end of it :).

referring back to the issue i had:
http://sourceware.org/ml/archer/2009-q1/msg00332.html

it looks like i remembered incorrectly, and according to Jim's 'For
the record,' portion
it is possible to do in a cvs/git friendly way.

sorry should have looked back in my emails for this earlier.

Re: [RFA] Rename python files.

[Joel Brobecker]

Thiago,

> How should said renaming be done, by submitting and committing a patch
> which removes the old file and adds a new one, or by moving things
> around in CVSROOT?

Let's just do what you suggested: "cvs rm" followed by "cvs add".
I looked at your Makefile.in changes, and they seem pretty
straightforward.  I will have a second look again as soon as you post
a full patch (you can exclude the files being renamed), to make sure
you did not miss any change elsewhere. (I really doubt it :-)

-- 
Joel

Re: [RFA] Rename python files.

[Thiago Jung Bauermann]

[-- Attachment #1: Type: Text/Plain, Size: 754 bytes --]

Hi Joel,

Em Quinta-feira 03 Setembro 2009 19:27:06 Joel Brobecker escreveu:
> > How should said renaming be done, by submitting and committing a patch
> > which removes the old file and adds a new one, or by moving things
> > around in CVSROOT?
>
> Let's just do what you suggested: "cvs rm" followed by "cvs add".
> I looked at your Makefile.in changes, and they seem pretty
> straightforward.  I will have a second look again as soon as you post
> a full patch (you can exclude the files being renamed), to make sure
> you did not miss any change elsewhere. (I really doubt it :-)

Thanks. Here's the patch, with ChangeLogs. After "cvs rm"ing and "cvs add"ing 
and applying the patch, all Python tests continue to pass.
-- 
[]'s
Thiago Jung Bauermann

[-- Attachment #2: rename-python.diff --]
[-- Type: text/x-patch, Size: 8858 bytes --]

2009-09-06  Thiago Jung Bauermann  <thiago.bauermann@gmail.com>

gdb/
	* Makefile.in (py-cmd.o): Renamed from python-cmd.o.  Updated
	references.
	(py-frame.o): Renamed from python-frame.o.  Updated references.
	(py-function.o): Renamed from python-function.o.  Updated references.
	(py-objfile.o): Renamed from python-objfile.o.  Updated references.
	(py-prettyprint.o): Renamed from python-prettyprint.o.  Updated references.
	(py-type.o): Renamed from python-type.o.  Updated references.
	(py-utils.o): Renamed from python-utils.o.  Updated references.
	(py-value.o): Renamed from python-value.o.  Updated references.
	* py-cmd.o: Renamed from python-cmd.o.
	* py-frame.o: Renamed from python-frame.o.
	* py-function.o: Renamed from python-function.o.
	* py-objfile.o: Renamed from python-objfile.o.
	* py-prettyprint.o: Renamed from python-prettyprint.o.
	* py-type.o: Renamed from python-type.o.
	* py-utils.o: Renamed from python-utils.o.
	* py-value.o: Renamed from python-value.o.

gdb/testsuite/
	* gdb.python/Makefile.in (EXECUTABLES): Adjust to new executable
	names, add missing ones.
	* gdb.python/py-cmd.exp: Rename from python-cmd.exp.
	* gdb.python/py-frame.c: Rename from python-frame.c.
	* gdb.python/py-frame.exp: Rename from python-frame.exp.  Adjust
	testfile name.
	* gdb.python/py-function.exp: Rename from python-function.exp.
	* gdb.python/py-mi.exp: Rename from python-mi.exp.  Adjust
	testfile name.
	* gdb.python/py-prettyprint.c: Rename from python-prettyprint.c.
	* gdb.python/py-prettyprint.exp: Rename from python-prettyprint.exp.
	Adjust testfile name.
	* gdb.python/py-prettyprint.py: Rename from python-prettyprint.py.
	* gdb.python/py-template.cc: Rename from python-template.cc.
	* gdb.python/py-template.exp: Rename from python-template.exp.
	Adjust testfile name.
	* gdb.python/py-value.c: Rename from python-value.c.
	* gdb.python/py-value.exp: Rename from python-value.exp.  Adjust
	testfile name.

Index: src/gdb/Makefile.in
===================================================================
--- src.orig/gdb/Makefile.in	2009-09-06 18:55:57.000000000 -0300
+++ src/gdb/Makefile.in	2009-09-06 19:10:53.000000000 -0300
@@ -264,24 +264,24 @@ SUBDIR_TUI_CFLAGS= \
 #
 SUBDIR_PYTHON_OBS = \
 	python.o \
-	python-cmd.o \
-	python-frame.o \
-	python-function.o \
-	python-objfile.o \
-	python-prettyprint.o \
-	python-type.o \
-	python-utils.o \
-	python-value.o
+	py-cmd.o \
+	py-frame.o \
+	py-function.o \
+	py-objfile.o \
+	py-prettyprint.o \
+	py-type.o \
+	py-utils.o \
+	py-value.o
 SUBDIR_PYTHON_SRCS = \
 	python/python.c \
-	python/python-cmd.c \
-	python/python-frame.c \
-	python/python-function.c \
-	python/python-objfile.c \
-	python/python-prettyprint.c \
-	python/python-type.c \
-	python/python-utils.c \
-	python/python-value.c
+	python/py-cmd.c \
+	python/py-frame.c \
+	python/py-function.c \
+	python/py-objfile.c \
+	python/py-prettyprint.c \
+	python/py-type.c \
+	python/py-utils.c \
+	python/py-value.c
 SUBDIR_PYTHON_DEPS =
 SUBDIR_PYTHON_LDFLAGS=
 SUBDIR_PYTHON_CFLAGS=
@@ -1919,36 +1919,36 @@ python.o: $(srcdir)/python/python.c
 	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python.c
 	$(POSTCOMPILE)
 
-python-cmd.o: $(srcdir)/python/python-cmd.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-cmd.c
+py-cmd.o: $(srcdir)/python/py-cmd.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-cmd.c
 	$(POSTCOMPILE)
 
-python-frame.o: $(srcdir)/python/python-frame.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-frame.c
+py-frame.o: $(srcdir)/python/py-frame.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-frame.c
 	$(POSTCOMPILE)
 
-python-function.o: $(srcdir)/python/python-function.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-function.c
+py-function.o: $(srcdir)/python/py-function.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-function.c
 	$(POSTCOMPILE)
 
-python-objfile.o: $(srcdir)/python/python-objfile.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-objfile.c
+py-objfile.o: $(srcdir)/python/py-objfile.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-objfile.c
 	$(POSTCOMPILE)
 
-python-prettyprint.o: $(srcdir)/python/python-prettyprint.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-prettyprint.c
+py-prettyprint.o: $(srcdir)/python/py-prettyprint.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-prettyprint.c
 	$(POSTCOMPILE)
 
-python-type.o: $(srcdir)/python/python-type.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-type.c
+py-type.o: $(srcdir)/python/py-type.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-type.c
 	$(POSTCOMPILE)
 
-python-utils.o: $(srcdir)/python/python-utils.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-utils.c
+py-utils.o: $(srcdir)/python/py-utils.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-utils.c
 	$(POSTCOMPILE)
 
-python-value.o: $(srcdir)/python/python-value.c
-	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-value.c
+py-value.o: $(srcdir)/python/py-value.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-value.c
 	$(POSTCOMPILE)
 
 #
Index: src/gdb/testsuite/gdb.python/Makefile.in
===================================================================
--- src.orig/gdb/testsuite/gdb.python/Makefile.in	2008-10-19 17:59:31.000000000 -0200
+++ src/gdb/testsuite/gdb.python/Makefile.in	2009-09-06 19:54:22.000000000 -0300
@@ -1,7 +1,7 @@
 VPATH = @srcdir@
 srcdir = @srcdir@
 
-EXECUTABLES = python-value
+EXECUTABLES = py-value py-prettyprint py-template
 
 all info install-info dvi install uninstall installcheck check:
 	@echo "Nothing to be done for $@..."
Index: src/gdb/testsuite/gdb.python/py-frame.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/py-frame.exp	2009-04-13 17:54:59.000000000 -0300
+++ src/gdb/testsuite/gdb.python/py-frame.exp	2009-09-06 19:54:22.000000000 -0300
@@ -20,7 +20,7 @@ if $tracelevel then {
     strace $tracelevel
 }
 
-set testfile "python-frame"
+set testfile "py-frame"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
Index: src/gdb/testsuite/gdb.python/py-mi.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/py-mi.exp	2009-05-27 22:09:20.000000000 -0300
+++ src/gdb/testsuite/gdb.python/py-mi.exp	2009-09-06 19:54:22.000000000 -0300
@@ -24,7 +24,7 @@ if [mi_gdb_start] {
     continue
 }
 
-set testfile "python-prettyprint"
+set testfile "py-prettyprint"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DMI}] != "" } {
Index: src/gdb/testsuite/gdb.python/py-prettyprint.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/py-prettyprint.exp	2009-07-10 07:35:17.000000000 -0300
+++ src/gdb/testsuite/gdb.python/py-prettyprint.exp	2009-09-06 19:54:22.000000000 -0300
@@ -20,7 +20,7 @@ if $tracelevel then {
     strace $tracelevel
 }
 
-set testfile "python-prettyprint"
+set testfile "py-prettyprint"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 
Index: src/gdb/testsuite/gdb.python/py-template.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/py-template.exp	2009-05-27 21:47:20.000000000 -0300
+++ src/gdb/testsuite/gdb.python/py-template.exp	2009-09-06 19:54:22.000000000 -0300
@@ -20,7 +20,7 @@ if $tracelevel then {
     strace $tracelevel
 }
 
-set testfile "python-template"
+set testfile "py-template"
 set srcfile ${testfile}.cc
 set binfile ${objdir}/${subdir}/${testfile}
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
Index: src/gdb/testsuite/gdb.python/py-value.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/py-value.exp	2009-07-10 07:35:17.000000000 -0300
+++ src/gdb/testsuite/gdb.python/py-value.exp	2009-09-06 19:54:43.000000000 -0300
@@ -20,7 +20,7 @@ if $tracelevel then {
     strace $tracelevel
 }
 
-set testfile "python-value"
+set testfile "py-value"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
@@ -257,7 +257,7 @@ proc test_value_in_inferior {} {
 
 # A few objfile tests.
 proc test_objfiles {} {
-    gdb_test "python\nok=False\nfor file in gdb.objfiles():\n  if 'python-value' in file.filename:\n    ok=True\nprint ok\nend" "True"
+    gdb_test "python\nok=False\nfor file in gdb.objfiles():\n  if 'py-value' in file.filename:\n    ok=True\nprint ok\nend" "True"
 
     gdb_test "python print gdb.objfiles()\[0\].pretty_printers" "\\\[\\\]"
 

Re: [RFA] Rename python files.

[Joel Brobecker]

> 2009-09-06  Thiago Jung Bauermann  <thiago.bauermann@gmail.com>
> 
> gdb/
> 	* Makefile.in (py-cmd.o): Renamed from python-cmd.o.  Updated
> 	references.
> 	(py-frame.o): Renamed from python-frame.o.  Updated references.
> 	(py-function.o): Renamed from python-function.o.  Updated references.
> 	(py-objfile.o): Renamed from python-objfile.o.  Updated references.
> 	(py-prettyprint.o): Renamed from python-prettyprint.o.  Updated references.
> 	(py-type.o): Renamed from python-type.o.  Updated references.
> 	(py-utils.o): Renamed from python-utils.o.  Updated references.
> 	(py-value.o): Renamed from python-value.o.  Updated references.
> 	* py-cmd.o: Renamed from python-cmd.o.
> 	* py-frame.o: Renamed from python-frame.o.
> 	* py-function.o: Renamed from python-function.o.
> 	* py-objfile.o: Renamed from python-objfile.o.
> 	* py-prettyprint.o: Renamed from python-prettyprint.o.
> 	* py-type.o: Renamed from python-type.o.
> 	* py-utils.o: Renamed from python-utils.o.
> 	* py-value.o: Renamed from python-value.o.
> 
> gdb/testsuite/
> 	* gdb.python/Makefile.in (EXECUTABLES): Adjust to new executable
> 	names, add missing ones.
> 	* gdb.python/py-cmd.exp: Rename from python-cmd.exp.
> 	* gdb.python/py-frame.c: Rename from python-frame.c.
> 	* gdb.python/py-frame.exp: Rename from python-frame.exp.  Adjust
> 	testfile name.
> 	* gdb.python/py-function.exp: Rename from python-function.exp.
> 	* gdb.python/py-mi.exp: Rename from python-mi.exp.  Adjust
> 	testfile name.
> 	* gdb.python/py-prettyprint.c: Rename from python-prettyprint.c.
> 	* gdb.python/py-prettyprint.exp: Rename from python-prettyprint.exp.
> 	Adjust testfile name.
> 	* gdb.python/py-prettyprint.py: Rename from python-prettyprint.py.
> 	* gdb.python/py-template.cc: Rename from python-template.cc.
> 	* gdb.python/py-template.exp: Rename from python-template.exp.
> 	Adjust testfile name.
> 	* gdb.python/py-value.c: Rename from python-value.c.
> 	* gdb.python/py-value.exp: Rename from python-value.exp.  Adjust
> 	testfile name.

Thanks for doing this, Thiago. This is approved.

-- 
Joel

Re: [RFA] Rename python files.

[Joel Brobecker]

Thiago,

> 2009-09-06  Thiago Jung Bauermann  <thiago.bauermann@gmail.com>
> 
> gdb/
> 	* Makefile.in (py-cmd.o): Renamed from python-cmd.o.  Updated
> 	references.
> 	(py-frame.o): Renamed from python-frame.o.  Updated references.
[...]

Just FYI: I committed your patch for you. I figured you were busy,
and I'm anxious to cut the next branch, so... ;-)

Thanks for the patch,
-- 
Joel