Re: [patch] [ia64] No start when GDB built with -lmcheck

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Mon, 17 Aug 2009 20:33:55 +0200, Tom Tromey wrote:
> I think if you go this route, you should remove the redundant
> initializations a couple lines down:
[...]
> Either approach is pre-approved.

I see I was too quick, checked it in with xzalloc.

Only simple ia64-rhel5-linux-gnu run was made.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2009-08/msg00122.html

--- src/gdb/ChangeLog	2009/08/25 00:23:06	1.10824
+++ src/gdb/ChangeLog	2009/08/25 14:06:44	1.10825
@@ -1,3 +1,10 @@
+2009-08-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Fix ia64 start crash when GDB built with -lmcheck.
+	* ia64-tdep.c (ia64_gdbarch_init): Allocate TDEP as cleared.  Remove
+	specific clearing of TDEP SIGCONTEXT_REGISTER_ADDRESS and
+	PC_IN_SIGTRAMP.
+
 2009-08-24  Keith Seitz  <keiths@redhat.com>
 
 	* c-exp.y (tokentab3): Add new token, ARROW_STAR. Changed all users.
--- src/gdb/ia64-tdep.c	2009/07/30 16:29:53	1.195
+++ src/gdb/ia64-tdep.c	2009/08/25 14:06:47	1.196
@@ -3671,12 +3671,9 @@
   if (arches != NULL)
     return arches->gdbarch;
 
-  tdep = xmalloc (sizeof (struct gdbarch_tdep));
+  tdep = xzalloc (sizeof (struct gdbarch_tdep));
   gdbarch = gdbarch_alloc (&info, tdep);
 
-  tdep->sigcontext_register_address = 0;
-  tdep->pc_in_sigtramp = 0;
-
   /* According to the ia64 specs, instructions that store long double
      floats in memory use a long-double format different than that
      used in the floating registers.  The memory format matches the