From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13209 invoked by alias); 25 Aug 2009 14:10:27 -0000 Received: (qmail 13138 invoked by uid 22791); 25 Aug 2009 14:10:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Aug 2009 14:10:04 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7PEA2ic023495 for ; Tue, 25 Aug 2009 10:10:02 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7PEA0CV031589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 25 Aug 2009 10:10:02 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n7PEA0gW013955; Tue, 25 Aug 2009 16:10:00 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n7PE9xIX013954; Tue, 25 Aug 2009 16:09:59 +0200 Date: Tue, 25 Aug 2009 14:18:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] [ia64] No start when GDB built with -lmcheck Message-ID: <20090825140959.GA12707@host0.dyn.jankratochvil.net> References: <20090816185543.GA19581@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00413.txt.bz2 On Mon, 17 Aug 2009 20:33:55 +0200, Tom Tromey wrote: > I think if you go this route, you should remove the redundant > initializations a couple lines down: [...] > Either approach is pre-approved. I see I was too quick, checked it in with xzalloc. Only simple ia64-rhel5-linux-gnu run was made. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2009-08/msg00122.html --- src/gdb/ChangeLog 2009/08/25 00:23:06 1.10824 +++ src/gdb/ChangeLog 2009/08/25 14:06:44 1.10825 @@ -1,3 +1,10 @@ +2009-08-25 Jan Kratochvil + + Fix ia64 start crash when GDB built with -lmcheck. + * ia64-tdep.c (ia64_gdbarch_init): Allocate TDEP as cleared. Remove + specific clearing of TDEP SIGCONTEXT_REGISTER_ADDRESS and + PC_IN_SIGTRAMP. + 2009-08-24 Keith Seitz * c-exp.y (tokentab3): Add new token, ARROW_STAR. Changed all users. --- src/gdb/ia64-tdep.c 2009/07/30 16:29:53 1.195 +++ src/gdb/ia64-tdep.c 2009/08/25 14:06:47 1.196 @@ -3671,12 +3671,9 @@ if (arches != NULL) return arches->gdbarch; - tdep = xmalloc (sizeof (struct gdbarch_tdep)); + tdep = xzalloc (sizeof (struct gdbarch_tdep)); gdbarch = gdbarch_alloc (&info, tdep); - tdep->sigcontext_register_address = 0; - tdep->pc_in_sigtramp = 0; - /* According to the ia64 specs, instructions that store long double floats in memory use a long-double format different than that used in the floating registers. The memory format matches the