From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH 3/N] some minor fixes in sim, gold, gdb
Date: Wed, 19 Aug 2009 19:34:00 -0000 [thread overview]
Message-ID: <20090819191456.GC7785@gmx.de> (raw)
In-Reply-To: <m34os3abxy.fsf@fleche.redhat.com>
* Tom Tromey wrote on Wed, Aug 19, 2009 at 08:35:53PM CEST:
> >>>>> "Ralf" == Ralf Wildenhues writes:
>
> Ralf> Of these changes, this one still needs approval:
>
> >> - sim/common/aclocal.m4: SIM_CHECK_MEMBER is alias for AC_CHECK_MEMBER now.
> >> This also needs to happen at the same time as the Autoconf update, to
> >> avoid exposing whatever bugs 2.59's AC_CHECK_MEMBER had.
> >> Is this ok or would you rather I replace every use of SIM_CHECK_MEMBER
> >> with AC_CHECK_MEMBER?
>
> This is ok.
Thanks, got all reviews now.
> I think it would be preferable to just do the replacement.
> However, I realize your patch is pretty huge already.
> So, if you would prefer to just change the definition of
> SIM_CHECK_MEMBER, that is fine by me.
Yes, I think I'd prefer to do this kind of cleanup later.
Cheers,
Ralf
next prev parent reply other threads:[~2009-08-19 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090815112928.GB5396@gmx.de>
[not found] ` <20090815113302.GC20172@gmx.de>
2009-08-18 18:56 ` Ralf Wildenhues
2009-08-19 18:43 ` Tom Tromey
2009-08-19 19:34 ` Ralf Wildenhues [this message]
2009-08-19 21:57 ` Frank Ch. Eigler
2009-08-22 17:35 ` Ralf Wildenhues
2009-08-25 20:05 ` fixup SIM_CHECK_* (was: [PATCH 3/N] some minor fixes in sim, gold, gdb) Ralf Wildenhues
2009-08-26 12:04 ` fixup SIM_CHECK_* Paolo Bonzini
2009-08-26 20:08 ` Ralf Wildenhues
[not found] ` <alpine.LSU.1.99.0908151331010.19553@acrux.dbai.tuwien.ac.at>
[not found] ` <20090816094922.GB25721@gmx.de>
[not found] ` <83ocqfitb3.fsf@gnu.org>
2009-08-25 19:55 ` Do not point to sources.redhat.com for autotools tarballs Ralf Wildenhues
2009-08-25 20:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819191456.GC7785@gmx.de \
--to=ralf.wildenhues@gmx.de \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox