From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24608 invoked by alias); 19 Aug 2009 19:15:07 -0000 Received: (qmail 24549 invoked by uid 22791); 19 Aug 2009 19:15:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 19 Aug 2009 19:15:00 +0000 Received: (qmail invoked by alias); 19 Aug 2009 19:14:57 -0000 Received: from xdsl-87-78-69-136.netcologne.de (EHLO localhost.localdomain) [87.78.69.136] by mail.gmx.net (mp055) with SMTP; 19 Aug 2009 21:14:57 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1Mdqca-00028D-DI; Wed, 19 Aug 2009 21:14:56 +0200 Date: Wed, 19 Aug 2009 19:34:00 -0000 From: Ralf Wildenhues To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH 3/N] some minor fixes in sim, gold, gdb Message-ID: <20090819191456.GC7785@gmx.de> References: <20090815112928.GB5396@gmx.de> <20090815113302.GC20172@gmx.de> <20090818184349.GE30742@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00316.txt.bz2 * Tom Tromey wrote on Wed, Aug 19, 2009 at 08:35:53PM CEST: > >>>>> "Ralf" == Ralf Wildenhues writes: > > Ralf> Of these changes, this one still needs approval: > > >> - sim/common/aclocal.m4: SIM_CHECK_MEMBER is alias for AC_CHECK_MEMBER now. > >> This also needs to happen at the same time as the Autoconf update, to > >> avoid exposing whatever bugs 2.59's AC_CHECK_MEMBER had. > >> Is this ok or would you rather I replace every use of SIM_CHECK_MEMBER > >> with AC_CHECK_MEMBER? > > This is ok. Thanks, got all reviews now. > I think it would be preferable to just do the replacement. > However, I realize your patch is pretty huge already. > So, if you would prefer to just change the definition of > SIM_CHECK_MEMBER, that is fine by me. Yes, I think I'd prefer to do this kind of cleanup later. Cheers, Ralf