From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [commit] Use unsigned int for crc32_table
Date: Thu, 13 Aug 2009 22:45:00 -0000 [thread overview]
Message-ID: <20090813223732.3AA698469B@localhost> (raw)
Hi.
While looking into a gnu_debuglink issue I found this.
It didn't seem to make sense to use an unsigned long on 64-bit hosts.
Committed.
2009-08-13 Doug Evans <dje@google.com>
* utils.c (gnu_debuglink_crc32): Store crc32_table as unsigned int
instead of unsigned long.
Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.216
diff -u -p -r1.216 utils.c
--- utils.c 6 Aug 2009 08:19:58 -0000 1.216
+++ utils.c 13 Aug 2009 00:40:53 -0000
@@ -3307,7 +3307,7 @@ xfullpath (const char *filename)
unsigned long
gnu_debuglink_crc32 (unsigned long crc, unsigned char *buf, size_t len)
{
- static const unsigned long crc32_table[256] = {
+ static const unsigned int crc32_table[256] = {
0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419,
0x706af48f, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4,
0xe0d5e91e, 0x97d2d988, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07,
reply other threads:[~2009-08-13 22:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813223732.3AA698469B@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox