From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6208 invoked by alias); 13 Aug 2009 22:37:46 -0000 Received: (qmail 6158 invoked by uid 22791); 13 Aug 2009 22:37:45 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Aug 2009 22:37:38 +0000 Received: from zps38.corp.google.com (zps38.corp.google.com [172.25.146.38]) by smtp-out.google.com with ESMTP id n7DMbYBU005143 for ; Thu, 13 Aug 2009 23:37:35 +0100 Received: from localhost (ruffy.mtv.corp.google.com [172.18.118.116]) by zps38.corp.google.com with ESMTP id n7DMbW8I016214 for ; Thu, 13 Aug 2009 15:37:32 -0700 Received: by localhost (Postfix, from userid 67641) id 3AA698469B; Thu, 13 Aug 2009 15:37:32 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [commit] Use unsigned int for crc32_table Message-Id: <20090813223732.3AA698469B@localhost> Date: Thu, 13 Aug 2009 22:45:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00185.txt.bz2 Hi. While looking into a gnu_debuglink issue I found this. It didn't seem to make sense to use an unsigned long on 64-bit hosts. Committed. 2009-08-13 Doug Evans * utils.c (gnu_debuglink_crc32): Store crc32_table as unsigned int instead of unsigned long. Index: utils.c =================================================================== RCS file: /cvs/src/src/gdb/utils.c,v retrieving revision 1.216 diff -u -p -r1.216 utils.c --- utils.c 6 Aug 2009 08:19:58 -0000 1.216 +++ utils.c 13 Aug 2009 00:40:53 -0000 @@ -3307,7 +3307,7 @@ xfullpath (const char *filename) unsigned long gnu_debuglink_crc32 (unsigned long crc, unsigned char *buf, size_t len) { - static const unsigned long crc32_table[256] = { + static const unsigned int crc32_table[256] = { 0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07,