From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] [2/9] Cell multi-arch: Implement tdesc <compatible> feature for Cell
Date: Fri, 31 Jul 2009 20:51:00 -0000 [thread overview]
Message-ID: <20090731182950.GA18478@caradoc.them.org> (raw)
In-Reply-To: <200907311551.n6VFp2Hg006613@d12av02.megacenter.de.ibm.com>
On Fri, Jul 31, 2009 at 05:51:02PM +0200, Ulrich Weigand wrote:
> Dan,
>
> when checking in the Cell/B.E. patches I ran into a small conflict with
> a change you committed as part of ARM VFP / NEON support. Basically,
> I need to use a different set of expedited registers with Cell/B.E.
> than with other PowerPC sub-platforms, and your patch to the features
> Makefile removed the capability for specifying that:
>
> - echo "expedite:$($*-expedite)" >> $(outdir)/$*.tmp
> + echo "expedite:$($(firstword $(subst -, ,$(notdir $*)))-expedite)" >> $(outdir)/$*.tmp
>
> To resolve this conflict, I've now added back that capability, but
> optionally: if there is an -expedite variable corresponding to the
> full platform string, use that; otherwise fall back to the -expedite
> variable for the core architecture.
>
> Does this look OK to you? If you prefer a different solution, please
> let me know, I'll be happy to fix it ...
This looks fine, thanks! All I wanted to do was reduce the
repitition; I regularly used to get conflicts on this chunk of
Makefile, and adding a new register set shouldn't really require
touching it.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2009-07-31 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 17:16 Ulrich Weigand
2009-07-22 18:35 ` Eli Zaretskii
2009-07-23 12:24 ` Ulrich Weigand
2009-07-23 19:29 ` Eli Zaretskii
2009-07-31 19:46 ` Ulrich Weigand
2009-07-31 20:51 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090731182950.GA18478@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox