From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4937 invoked by alias); 31 Jul 2009 18:29:59 -0000 Received: (qmail 4927 invoked by uid 22791); 31 Jul 2009 18:29:58 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Jul 2009 18:29:52 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0877210C2D; Fri, 31 Jul 2009 18:29:51 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id DEDAC1072B; Fri, 31 Jul 2009 18:29:50 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MWwrW-0004oP-2f; Fri, 31 Jul 2009 14:29:50 -0400 Date: Fri, 31 Jul 2009 20:51:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] [2/9] Cell multi-arch: Implement tdesc feature for Cell Message-ID: <20090731182950.GA18478@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200907221715.n6MHFBhc013316@d12av02.megacenter.de.ibm.com> <200907311551.n6VFp2Hg006613@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907311551.n6VFp2Hg006613@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00767.txt.bz2 On Fri, Jul 31, 2009 at 05:51:02PM +0200, Ulrich Weigand wrote: > Dan, > > when checking in the Cell/B.E. patches I ran into a small conflict with > a change you committed as part of ARM VFP / NEON support. Basically, > I need to use a different set of expedited registers with Cell/B.E. > than with other PowerPC sub-platforms, and your patch to the features > Makefile removed the capability for specifying that: > > - echo "expedite:$($*-expedite)" >> $(outdir)/$*.tmp > + echo "expedite:$($(firstword $(subst -, ,$(notdir $*)))-expedite)" >> $(outdir)/$*.tmp > > To resolve this conflict, I've now added back that capability, but > optionally: if there is an -expedite variable corresponding to the > full platform string, use that; otherwise fall back to the -expedite > variable for the core architecture. > > Does this look OK to you? If you prefer a different solution, please > let me know, I'll be happy to fix it ... This looks fine, thanks! All I wanted to do was reduce the repitition; I regularly used to get conflicts on this chunk of Makefile, and adding a new register set shouldn't really require touching it. -- Daniel Jacobowitz CodeSourcery