From: "drow@false.org" <drow@false.org>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] small change for better error reporting in remote.c
Date: Fri, 31 Jul 2009 09:00:00 -0000 [thread overview]
Message-ID: <20090730213019.GB3955@caradoc.them.org> (raw)
In-Reply-To: <4A70E268.6010401@vmware.com>
On Wed, Jul 29, 2009 at 04:59:36PM -0700, Michael Snyder wrote:
> @@ -5189,7 +5192,10 @@ store_registers_using_G (const struct re
> /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets
> updated. */
> bin2hex (regs, p, rsa->sizeof_g_packet);
> - remote_send (&rs->buf, &rs->buf_size);
> + putpkt (rs->buf);
> + getpkt (&rs->buf, &rs->buf_size, 0);
> + if (rs->buf[0] == 'E')
> + error (_("Could not write registers"));
> }
>
> /* Store register REGNUM, or all registers if REGNUM == -1, from the contents
Can't you use packet_ok like elsewhere? Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-07-30 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 0:41 Michael Snyder
2009-07-31 9:00 ` drow [this message]
2009-07-31 21:00 ` Michael Snyder
2009-07-31 21:43 ` Daniel Jacobowitz
2009-07-31 22:13 ` Michael Snyder
2009-07-31 22:09 ` Pedro Alves
2009-07-31 22:15 ` Michael Snyder
2009-07-31 22:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730213019.GB3955@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox