From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12496 invoked by alias); 30 Jul 2009 21:30:31 -0000 Received: (qmail 12473 invoked by uid 22791); 30 Jul 2009 21:30:29 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Jul 2009 21:30:21 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id EAF2E1062D; Thu, 30 Jul 2009 21:30:19 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id B5E4010555; Thu, 30 Jul 2009 21:30:19 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MWdCd-00012a-14; Thu, 30 Jul 2009 17:30:19 -0400 Date: Fri, 31 Jul 2009 09:00:00 -0000 From: "drow@false.org" To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [RFC] small change for better error reporting in remote.c Message-ID: <20090730213019.GB3955@caradoc.them.org> Mail-Followup-To: Michael Snyder , "gdb-patches@sourceware.org" References: <4A70E268.6010401@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A70E268.6010401@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00756.txt.bz2 On Wed, Jul 29, 2009 at 04:59:36PM -0700, Michael Snyder wrote: > @@ -5189,7 +5192,10 @@ store_registers_using_G (const struct re > /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets > updated. */ > bin2hex (regs, p, rsa->sizeof_g_packet); > - remote_send (&rs->buf, &rs->buf_size); > + putpkt (rs->buf); > + getpkt (&rs->buf, &rs->buf_size, 0); > + if (rs->buf[0] == 'E') > + error (_("Could not write registers")); > } > > /* Store register REGNUM, or all registers if REGNUM == -1, from the contents Can't you use packet_ok like elsewhere? Otherwise OK. -- Daniel Jacobowitz CodeSourcery