Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sourceware.org
Subject: Re: nto_extra_thread_info
Date: Tue, 28 Jul 2009 13:24:00 -0000	[thread overview]
Message-ID: <200907281229.06726.pedro@codesourcery.com> (raw)
In-Reply-To: <4A6E0B5F.6090901@qnx.com>

On Monday 27 July 2009 21:17:35, Aleksandar Ristovski wrote:
> Pedro Alves wrote:
> > This "We return tidinfo." looks out of place though.
> > I suspect this whole comment was copied from the devctl's docs or
> > implementation.
> 
> Indeed. I copied it. (Ironically, I also wrote it where I 
> copied it from). I changed wording to be more applicable to 
> this place.

Thanks!

> Changed to "offsetof".

Thanks.  ( you missed a space between offsetof and '(' )

> >>   2009-06-12  Aleksandar Ristovski  <aristovski@qnx.com>
> >>
> >>         * nto-tdep.c (nto_thread_state_str): New array.
> >>         (nto_extra_thread_info): New function definition.
> >>         * nto-tdep.h (gdbthread.h): New include.
> >>         (private_thread_info): New struct.
> >>         (nto_extra_thread_info): New declaration.
> >>         * nto-procfs.c (procfs_thread_alive): Properly check if
> >>         thread is still alive.
> >>         (update_thread_private_data_name, update_thread_private_data): New
> >>         function definition.
> >>         (procfs_find_new_threads): Fetch thread private data.
> >>         (init_procfs_ops): Register to_extra_thread_info.

OK.

-- 
Pedro Alves


  reply	other threads:[~2009-07-28 11:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 18:57 nto_extra_thread_info Aleksandar Ristovski
2009-07-07 16:29 ` nto_extra_thread_info Aleksandar Ristovski
2009-07-21 17:09   ` nto_extra_thread_info Aleksandar Ristovski
2009-07-24 16:47 ` nto_extra_thread_info Pedro Alves
2009-07-27 20:55   ` nto_extra_thread_info Aleksandar Ristovski
2009-07-28 13:24     ` Pedro Alves [this message]
2009-07-28 14:34       ` nto_extra_thread_info Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907281229.06726.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=aristovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox