From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7125 invoked by alias); 28 Jul 2009 11:29:16 -0000 Received: (qmail 7110 invoked by uid 22791); 28 Jul 2009 11:29:15 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jul 2009 11:29:10 +0000 Received: (qmail 31268 invoked from network); 28 Jul 2009 11:29:08 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Jul 2009 11:29:08 -0000 From: Pedro Alves To: Aleksandar Ristovski Subject: Re: nto_extra_thread_info Date: Tue, 28 Jul 2009 13:24:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200907241516.48134.pedro@codesourcery.com> <4A6E0B5F.6090901@qnx.com> In-Reply-To: <4A6E0B5F.6090901@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907281229.06726.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00673.txt.bz2 On Monday 27 July 2009 21:17:35, Aleksandar Ristovski wrote: > Pedro Alves wrote: > > This "We return tidinfo." looks out of place though. > > I suspect this whole comment was copied from the devctl's docs or > > implementation. > > Indeed. I copied it. (Ironically, I also wrote it where I > copied it from). I changed wording to be more applicable to > this place. Thanks! > Changed to "offsetof". Thanks. ( you missed a space between offsetof and '(' ) > >> 2009-06-12 Aleksandar Ristovski > >> > >> * nto-tdep.c (nto_thread_state_str): New array. > >> (nto_extra_thread_info): New function definition. > >> * nto-tdep.h (gdbthread.h): New include. > >> (private_thread_info): New struct. > >> (nto_extra_thread_info): New declaration. > >> * nto-procfs.c (procfs_thread_alive): Properly check if > >> thread is still alive. > >> (update_thread_private_data_name, update_thread_private_data): New > >> function definition. > >> (procfs_find_new_threads): Fetch thread private data. > >> (init_procfs_ops): Register to_extra_thread_info. OK. -- Pedro Alves