From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [obv] i386-tdep.c: Fix call to read_memory_unsigned_integer
Date: Thu, 09 Jul 2009 23:59:00 -0000 [thread overview]
Message-ID: <20090709232906.93AD3846E2@localhost> (raw)
Hi.
Checked in as obvious.
This fixes the regression in the i386-disp-step.exp testcase.
2009-07-09 Doug Evans <dje@google.com>
* i386-tdep.c (i386_displaced_step_fixup): Fix order of arguments
to read_memory_unsigned_integer.
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.280
diff -u -p -r1.280 i386-tdep.c
--- i386-tdep.c 2 Jul 2009 17:25:54 -0000 1.280
+++ i386-tdep.c 9 Jul 2009 23:25:52 -0000
@@ -523,7 +523,7 @@ i386_displaced_step_fixup (struct gdbarc
const ULONGEST retaddr_len = 4;
regcache_cooked_read_unsigned (regs, I386_ESP_REGNUM, &esp);
- retaddr = read_memory_unsigned_integer (esp, byte_order, retaddr_len);
+ retaddr = read_memory_unsigned_integer (esp, retaddr_len, byte_order);
retaddr = (retaddr - insn_offset) & 0xffffffffUL;
write_memory_unsigned_integer (esp, retaddr_len, byte_order, retaddr);
reply other threads:[~2009-07-09 23:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709232906.93AD3846E2@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox