From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26274 invoked by alias); 9 Jul 2009 23:29:22 -0000 Received: (qmail 26266 invoked by uid 22791); 9 Jul 2009 23:29:21 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jul 2009 23:29:12 +0000 Received: from spaceape10.eur.corp.google.com (spaceape10.eur.corp.google.com [172.28.16.144]) by smtp-out.google.com with ESMTP id n69NT9BD029303 for ; Fri, 10 Jul 2009 00:29:09 +0100 Received: from localhost (ruffy.mtv.corp.google.com [172.18.118.116]) by spaceape10.eur.corp.google.com with ESMTP id n69NT7nx009588 for ; Thu, 9 Jul 2009 16:29:07 -0700 Received: by localhost (Postfix, from userid 67641) id 93AD3846E2; Thu, 9 Jul 2009 16:29:06 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [obv] i386-tdep.c: Fix call to read_memory_unsigned_integer Message-Id: <20090709232906.93AD3846E2@localhost> Date: Thu, 09 Jul 2009 23:59:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00298.txt.bz2 Hi. Checked in as obvious. This fixes the regression in the i386-disp-step.exp testcase. 2009-07-09 Doug Evans * i386-tdep.c (i386_displaced_step_fixup): Fix order of arguments to read_memory_unsigned_integer. Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.280 diff -u -p -r1.280 i386-tdep.c --- i386-tdep.c 2 Jul 2009 17:25:54 -0000 1.280 +++ i386-tdep.c 9 Jul 2009 23:25:52 -0000 @@ -523,7 +523,7 @@ i386_displaced_step_fixup (struct gdbarc const ULONGEST retaddr_len = 4; regcache_cooked_read_unsigned (regs, I386_ESP_REGNUM, &esp); - retaddr = read_memory_unsigned_integer (esp, byte_order, retaddr_len); + retaddr = read_memory_unsigned_integer (esp, retaddr_len, byte_order); retaddr = (retaddr - insn_offset) & 0xffffffffUL; write_memory_unsigned_integer (esp, retaddr_len, byte_order, retaddr);