From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] testsuite: Fix racy gdb.mi/mi-nsthrexec.exp FAIL
Date: Tue, 30 Jun 2009 20:28:00 -0000 [thread overview]
Message-ID: <20090630202552.GA12796@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <200906302037.51187.pedro@codesourcery.com>
On Tue, 30 Jun 2009 21:37:50 +0200, Pedro Alves wrote:
> On Tuesday 30 June 2009 19:23:34, Jan Kratochvil wrote:
>
> > @@ -59880,10 +59843,9 @@ Expecting: ^(-thread-info[
> > ]+[(]gdb[)]
> > [ ]*)
> > -thread-info
> > -~"Current language: auto; currently asm\n"
[...]
> This must be from the language_info call in inf-loop.c, that
> is always called when something stops. In light of non-stop mode,
> this is a weird place to output this (and to change expected
> language) --- the thread that just stopped may not be the
> current thread.
Understood, admitting I did not found this point out.
> Other testsuite code may be using racy .*'s simply because
> it is not being exercised in non-stop mode (we had to remove a bunch of
> those before, tightening the expected strings up),
OK, thanks for the notice to be aware of it.
> ... Ok.
Checked-in:
http://sourceware.org/ml/gdb-cvs/2009-06/msg00204.html
Thanks for the review,
Jan
prev parent reply other threads:[~2009-06-30 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 18:23 Jan Kratochvil
2009-06-30 19:36 ` Pedro Alves
2009-06-30 20:28 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630202552.GA12796@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox