From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17989 invoked by alias); 30 Jun 2009 20:28:10 -0000 Received: (qmail 17929 invoked by uid 22791); 30 Jun 2009 20:28:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Jun 2009 20:27:58 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5UKPvDs032698; Tue, 30 Jun 2009 16:25:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5UKPuKU018436; Tue, 30 Jun 2009 16:25:56 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5UKPtEm029610; Tue, 30 Jun 2009 16:25:56 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n5UKPsiE013131; Tue, 30 Jun 2009 22:25:54 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n5UKPq0B013127; Tue, 30 Jun 2009 22:25:52 +0200 Date: Tue, 30 Jun 2009 20:28:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix racy gdb.mi/mi-nsthrexec.exp FAIL Message-ID: <20090630202552.GA12796@host0.dyn.jankratochvil.net> References: <20090630182334.GA30261@host0.dyn.jankratochvil.net> <200906302037.51187.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200906302037.51187.pedro@codesourcery.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00892.txt.bz2 On Tue, 30 Jun 2009 21:37:50 +0200, Pedro Alves wrote: > On Tuesday 30 June 2009 19:23:34, Jan Kratochvil wrote: > > > @@ -59880,10 +59843,9 @@ Expecting: ^(-thread-info[ > > ]+[(]gdb[)] > > [ ]*) > > -thread-info > > -~"Current language: auto; currently asm\n" [...] > This must be from the language_info call in inf-loop.c, that > is always called when something stops. In light of non-stop mode, > this is a weird place to output this (and to change expected > language) --- the thread that just stopped may not be the > current thread. Understood, admitting I did not found this point out. > Other testsuite code may be using racy .*'s simply because > it is not being exercised in non-stop mode (we had to remove a bunch of > those before, tightening the expected strings up), OK, thanks for the notice to be aware of it. > ... Ok. Checked-in: http://sourceware.org/ml/gdb-cvs/2009-06/msg00204.html Thanks for the review, Jan