From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [6/7] Introduce per-type architecture
Date: Fri, 26 Jun 2009 17:30:00 -0000 [thread overview]
Message-ID: <200906261730.n5QHUDAv004603@d12av02.megacenter.de.ibm.com> (raw)
Tom Tromey wrote:
> I read through this patch series. Well... I skimmed most of it, since
> it mostly seemed mechanical.
>
> It all seems reasonable to me.
Thanks for the review.
> I noticed that many of the new functions don't have introductory
> comments. We've been asking everybody to write these recently; and I
> think the quoted text here would be good to have in the code
> somewhere. So, I would like to ask that this be split up and attached
> to the appropriate functions.
You're right. I'll be happy to add such comments.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next reply other threads:[~2009-06-26 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 17:30 Ulrich Weigand [this message]
2009-06-29 13:29 ` Ulrich Weigand
-- strict thread matches above, loose matches on Subject: below --
2009-06-26 16:42 Ulrich Weigand
2009-06-26 17:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906261730.n5QHUDAv004603@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox